Skip to content

Remove/change misleading parameter help #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RincewindsHat merged 1 commit into from
Sep 15, 2026
Merged

Remove/change misleading parameter help #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/cpu.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ var cpuCmd = &cobra.Command{

func init() {
rootCmd.AddCommand(cpuCmd)
cpuCmd.Flags().StringVarP(&cpuWarning, "warning", "w", "80", "Warning threshold in percent")
cpuCmd.Flags().StringVarP(&cpuCritical, "critical", "c", "90", "Critical threshold in percent")
cpuCmd.Flags().StringVarP(&cpuWarning, "warning", "w", "80", "Warning threshold range in percent")
cpuCmd.Flags().StringVarP(&cpuCritical, "critical", "c", "90", "Critical threshold range in percent")
}

// Query for CPU usage of the given machine, exit with UNKNOWN on query errors.
Expand Down
4 changes: 2 additions & 2 deletions cmd/datastore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ var datastoreCmd = &cobra.Command{
func init() {
rootCmd.AddCommand(datastoreCmd)

datastoreCmd.Flags().StringVarP(&datastoreWarning, "warning", "w", "80", "Warning threshold in percent")
datastoreCmd.Flags().StringVarP(&datastoreCritical, "critical", "c", "90", "Critical threshold in percent")
datastoreCmd.Flags().StringVarP(&datastoreWarning, "warning", "w", "80", "Warning threshold range in percent")
datastoreCmd.Flags().StringVarP(&datastoreCritical, "critical", "c", "90", "Critical threshold range in percent")
datastoreCmd.Flags().StringVarP(&datastore, "datastore", "", "", "Name of the datastore to check")
}

Expand Down
6 changes: 3 additions & 3 deletions cmd/hba.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ var hbaCritThreshold *check.Threshold

var hbaCmd = &cobra.Command{
Use: "hba",
Short: "Checks attached HBAs. Uses negative thresholds as parameters, e.g. 10:",
Short: "Checks attached HBAs. Uses threshold ranges as parameters, e.g. 10:",
Run: func(_ *cobra.Command, _ []string) {
queryHba()
},
Expand All @@ -25,8 +25,8 @@ var hbaCmd = &cobra.Command{
func init() {
rootCmd.AddCommand(hbaCmd)

hbaCmd.Flags().StringVarP(&hbaWarning, "warning", "w", "2:", "Warning threshold (\"less than X available\")")
hbaCmd.Flags().StringVarP(&hbaCritical, "critical", "c", "1:", "Critical threshold (\"less than X available\")")
hbaCmd.Flags().StringVarP(&hbaWarning, "warning", "w", "2:", "Warning threshold range")
hbaCmd.Flags().StringVarP(&hbaCritical, "critical", "c", "1:", "Critical threshold range")
}

func queryHba() {
Expand Down
4 changes: 2 additions & 2 deletions cmd/memory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ var memoryCmd = &cobra.Command{
func init() {
rootCmd.AddCommand(memoryCmd)

memoryCmd.Flags().StringVarP(&memoryWarning, "warning", "w", "80", "Warning threshold in percent")
memoryCmd.Flags().StringVarP(&memoryCritical, "critical", "c", "90", "Critical threshold in percent")
memoryCmd.Flags().StringVarP(&memoryWarning, "warning", "w", "80", "Warning threshold range in percent")
memoryCmd.Flags().StringVarP(&memoryCritical, "critical", "c", "90", "Critical threshold range in percent")
}

// Query for memory usage of the given machine, exit with UNKNOWN on query errors.
Expand Down
6 changes: 3 additions & 3 deletions cmd/nic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ var nicCritThreshold *check.Threshold

var nicCmd = &cobra.Command{
Use: "nic",
Short: "Checks the number of attached NICs. Uses negative thresholds as parameters, e.g. 10:",
Short: "Checks the number of attached NICs. Uses threshold ranges as parameters, e.g. 10:",
Run: func(_ *cobra.Command, _ []string) {
queryNic()
},
Expand All @@ -25,8 +25,8 @@ var nicCmd = &cobra.Command{
func init() {
rootCmd.AddCommand(nicCmd)

nicCmd.Flags().StringVarP(&nicWarning, "warning", "w", "2:", "Warning threshold (\"less than X available\")")
nicCmd.Flags().StringVarP(&nicCritical, "critical", "c", "1:", "Critical threshold (\"less than X available\")")
nicCmd.Flags().StringVarP(&nicWarning, "warning", "w", "2:", "Warning threshold range")
nicCmd.Flags().StringVarP(&nicCritical, "critical", "c", "1:", "Critical threshold range")
}

func queryNic() {
Expand Down
4 changes: 2 additions & 2 deletions cmd/temperature.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ var temperatureCmd = &cobra.Command{
func init() {
rootCmd.AddCommand(temperatureCmd)

temperatureCmd.Flags().StringVarP(&temperatureWarning, "warning", "w", "50", "Warning threshold")
temperatureCmd.Flags().StringVarP(&temperatureCritical, "critical", "c", "60", "Critical threshold")
temperatureCmd.Flags().StringVarP(&temperatureWarning, "warning", "w", "50", "Warning threshold range")
temperatureCmd.Flags().StringVarP(&temperatureCritical, "critical", "c", "60", "Critical threshold range")
temperatureCmd.Flags().StringVarP(&temperatureSensor, "sensor", "", "%", "Sensor name filter (supports SQL LIKE pattern)")
}

Expand Down