Skip to content

Visualizer - #401

Open
Doralitze wants to merge 73 commits into
mainfrom
visualizer1
Open

Visualizer#401
Doralitze wants to merge 73 commits into
mainfrom
visualizer1

Conversation

@Doralitze

@Doralitze Doralitze commented May 11, 2026

Copy link
Copy Markdown
Member

The following issues still need to be resolved:

  • Fix issue that W channel is not used in RGBW mode
  • Fix issue that directly looking into a beam does not render any light. A lense flare is not required, just a flat texture providing the current color
  • Fix behavior of dimmer channel
  • Load max movement angles from fixture definitions.
  • Refactor source code to implement separation of concerns (for example one should have different classes for different fixture renderers
  • Add setting (General) to show file to load specified stage file automatically. @Doralitze will take care of this.
  • Remove default stage file from source tree.

Remaining issues will be addressed in future work.

@Doralitze

Doralitze commented May 11, 2026

Copy link
Copy Markdown
Member Author
  • Regarding refactoring: model/stage.py should be a package with classes from that file being in their own files.
  • resource/data/stage.yaml should be removed.
  • stage_editor_widget must be splitted into multiple files as well.
  • In addition, the GL control logic and side bar widgets in stage_editor_widget should be separated.
  • The shaders in stage_gl_widget.py should be separate files in the source tree.
  • The model loading should be moved from stage_gl_widget.py to a separate class and file.
  • The methods _traverse_gltf and _upload_vao also belongs to the 3D model class.
  • A visualizer fixture needs to have its own class with capability mixins (for example can_move or emits_light) to ensure one can add fixtures with different traits (For example an LED bar which cannot move but has many pixels in its matrix) later on.
  • Fix ruff issues

After each change, functionality must be tested in order to avoid regression.
After all of this is addressed, a second round of refactoring might be in order.

@Doralitze Doralitze added the visualizer Issues and Tasks related to the visualizer component label May 18, 2026
@Doralitze
Doralitze requested a review from CorsCodini August 30, 2026 13:49
@Doralitze
Doralitze marked this pull request as ready for review August 30, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

visualizer Issues and Tasks related to the visualizer component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing layer help gifs

3 participants