feat(text): register MiniMax-M2.7 as a text model option - #210
Open
octo-patch wants to merge 1 commit into
Open
Conversation
Add a text model registry (src/commands/text/models.ts) listing the MiniMax-M3 (default) and MiniMax-M2.7 model IDs, mirroring the existing music model registry pattern. The chat command, repl command, and text SDK module now resolve the effective model and validate explicit --model values against this registry, so MiniMax-M2.7 is surfaced as a first-class option in help text, the SDK, and validation errors. Help text and SDK docs list the supported models.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason: text SDK defaults to MiniMax-M3 but had no MiniMax-M2.7 model option or model registry entry.
Changes
src/commands/text/models.ts) listing the supported MiniMax text model IDs (MiniMax-M3default,MiniMax-M2.7), mirroring the existing music model registry pattern (src/commands/music/models.ts).text chatandtext replnow resolve the effective model through the registry and validate an explicit--modelvalue against it, surfacingMiniMax-M2.7as a first-class option in--helpand rejecting unknown model IDs with a clear usage error.sdk.textresolves its default model from the same registry and validates an explicitmodelfield the same way, keeping the CLI and SDK in lockstep.SDK.md, andskill/SKILL.mdlist the supported text models.Checks
bun run typecheck(tsc --noEmit) — cleanbun run lint— 0 errorsbun test— 414 pass / 0 fail (added coverage for the registry, the chat invalid-model path, and the SDK invalid-model path)bun run build—dist/mmx.mjs+dist/sdk.mjsproducedNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.