add exclusion

[James Bruten (james-bruten-mo)]

PR Summary

Sci/Tech Reviewer:
Code Reviewer: Erica Neininger (@ericaneininger)

This is required for MetOffice/lfric_apps#624, but can go on immediately

Code Quality Checklist

• I have performed a self-review of my own code
• My code follows the project's style guidelines
• Comments have been included that aid understanding and enhance the readability of the code
• My changes generate no new warnings
• All automated checks in the CI pipeline have completed successfully

Testing

• This change has been tested appropriately (please describe)

Security Considerations

• I have reviewed my changes for potential security issues
• Sensitive data is properly handled (if applicable)
• Authentication and authorisation are properly implemented (if applicable)

AI Assistance and Attribution

• Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Sci/Tech Review

• I understand this area of code and the changes being added
• The proposed changes correspond to the pull request description
• Documentation is sufficient (do documentation papers need updating)
• Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

• All dependencies have been resolved
• Related Issues have been properly linked and addressed
• Code quality standards have been met
• Tests are adequate and have passed
• Security considerations have been addressed
• Performance impact is acceptable

[Erica Neininger (ericaneininger)]

Just to be clear, I think that "lfric_coupled_rivers" app been replaced by "coupled_rivers" in the related lfric_apps PR. This poses a couple of questions -

• Should "lfric_coupled_rivers" be removed from the exclusion list?
• Does lfric_macros/apply_macros.py need updating around line 1093, where it references "lfric_coupled_rivers"?

[James Bruten (james-bruten-mo)]

Just to be clear, I think that "lfric_coupled_rivers" app been replaced by "coupled_rivers" in the related lfric_apps PR. This poses a couple of questions -

• Should "lfric_coupled_rivers" be removed from the exclusion list?
• Does lfric_macros/apply_macros.py need updating around line 1093, where it references "lfric_coupled_rivers"?

Thanks Erica, that's a great catch - apply_macros now updated too.
I've left the lfric_coupled_rivers in place so it's backwards compatible for now

[Erica Neininger (ericaneininger)]

Thanks for the update. Happy to approve.