ci: reject pull request titles the changelog would drop - #115
Merged
jdhughes-dev merged 1 commit intoSep 6, 2026
Merged
Conversation
Pull requests are squash merged, so the title becomes the commit message the release notes are generated from, and git-cliff drops anything that is not a conventional commit header without saying so. The logger_level parameter was added by such a commit and was missing from the 1.0.0 notes; 63 commits were skipped in that release. Titles are now checked, except on the release and reset pull requests, which a bot opens and which are not squash merged. The publishing guide records that PyPI matches a trusted publisher on the organisation, repository, workflow and environment names, since renaming the organisation invalidated the publisher and nothing reported it until the 1.0.0 release failed to upload.
wpbonelli
added a commit
to wpbonelli/modflow-devtools
that referenced
this pull request
Sep 8, 2026
Pull requests are squash merged, so the title becomes the commit message the release notes are generated from, and git-cliff drops anything that is not a conventional commit header without saying so. The title check runs on every pull request except the release and reset ones, which a bot opens and which are not squash merged. Ports MODFLOW-ORG/modflowapi#115. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GAtFFGBtJSR8f1bY2VNEZT
wpbonelli
added a commit
to wpbonelli/flopy
that referenced
this pull request
Sep 8, 2026
Development pull requests are squash merged, so the title becomes the commit message the release notes are generated from, and git-cliff drops anything that is not a conventional commit header without saying so. The title check runs on every pull request except the bot-opened release and reset ones, which are not squash merged. Ports MODFLOW-ORG/modflowapi#115. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GAtFFGBtJSR8f1bY2VNEZT
wpbonelli
added a commit
to wpbonelli/flopy
that referenced
this pull request
Sep 8, 2026
Development pull requests are squash merged, so the title becomes the commit message the release notes are generated from, and git-cliff drops anything that is not a conventional commit header without saying so. The title check runs on every pull request except the bot-opened release and reset ones, which are not squash merged. Ports MODFLOW-ORG/modflowapi#115. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GAtFFGBtJSR8f1bY2VNEZT (cherry picked from commit b63d26b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things that broke quietly during the 1.0.0 release.
support logger_level init parameter (#92)was missing from the 1.0.0 notes for this reason; 63 commits were skipped in that release. Titles are now checked, except on the release and reset pull requests, which a bot opens.The check cannot tell whether the type is the right one: a user facing change titled
chore:still passes and is still dropped. The guide says to read the generated changelog on the release pull request before merging.