IsMultiFile now follows the multiFile argument only (Issue #679) - #693
Merged
Conversation
- Exact production fix: IsMultiFile now follows the multiFile argument only.
- Three constructor cases tested:
- single file + false stays single-file
- single file + true expands rollover siblings
- array constructor remains multi-file
- Monitoring truncation test confirms a single-file reader reports NewFile, not rollover.
- Existing BufferShiftTest was left unchanged and run.
- git diff --check reports no whitespace errors.
Hirogen
requested changes
Aug 25, 2026
Contributor
Author
|
Check please |
Hirogen
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsMultiFile now follows the multiFile argument only as you suggested:
IsMultiFile = multiFile;
Tested files according description in #679 :
app.log
app.log.1
Tested, passed.