feat(ui): make the monitored-state pill toggle monitoring - #887
Open
krejko wants to merge 1 commit into
Open
Conversation
On the author and series collection pages the "Monitoring Author" / "Not Monitored" pill sits in the hero where people look, but was inert. The control that actually toggles is a toolbar button measured at y=669 on a 1200px-wide window - below the fold, behind the whole hero - so the page reads as having no way to monitor at all. Pill gains an optional interactive prop that renders a button instead of a span, defaulting to false so the existing read-only usages are unchanged. The click emit is declared rather than left to attribute fallthrough, because the template now has v-if/v-else roots. Verified in a browser: the pill renders as a button above the fold, clicking posts to /authors/monitoring, the label flips to "Monitoring Author" with the primary variant, and clicking again returns it to "Not Monitored". No Vue fallthrough warning is emitted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the author and series collection pages, the "Monitoring Author" / "Not Monitored" pill sits in the hero where people look, but is inert. The control that actually toggles is a toolbar button — measured at
y: 669on a 1200px-wide window, below the fold behind the entire hero section. The page reads as having no way to monitor.Pillgains an optionalinteractiveprop that renders a<button>instead of a<span>, defaulting tofalseso the six existing read-only usages are unchanged.The
clickemit is declared explicitly rather than left to attribute fallthrough, since the template now hasv-if/v-elseroots.Verified in a browser:
<BUTTON>,cursor: pointer,y: 259— above the foldPOST /api/v1/authors/monitoringfiredpill-primaryNo Vue fallthrough warning in the console.