fix(ui): stop styling unmonitored books as a destructive state - #885
Open
krejko wants to merge 1 commit into
Open
fix(ui): stop styling unmonitored books as a destructive state#885krejko wants to merge 1 commit into
krejko wants to merge 1 commit into
Conversation
The unmonitored badge used the same red as the delete control, so "Not Added" and "Not Monitored" read with the severity of deleting a file. Both are ordinary states, not warnings. Recoloured to neutral slate with muted text, keeping green for monitored so the pair still reads at a glance, and leaving red to mean delete. The eye and crossed-eye icons were already correct and are unchanged, so the badges now match the author and series pills in the same views. Three separate rules defined this badge in CollectionView, the last of which used a different red and a shorthand background, so it silently overrode the other two.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unmonitored badge uses the same red as the delete control, so "Not Added" and "Not Monitored" read with the severity of deleting a file. Both are ordinary states.
rgba(244,67,54,0.9), white textrgba(148,163,184,0.15), muted textThe
PhEye/PhEyeSlashicons were already right and are untouched, so the badges now match the author and series pills in the same views.Worth noting for review: three separate rules define
.monitored-badge.unmonitoredinCollectionView, and the last one uses a different red plus a shorthandbackground, so it silently overrides the other two. All are updated.