fix(ui): theme the collection card detail text - #884
Open
krejko wants to merge 1 commit into
Open
Conversation
With item details toggled on, the text under each cover is unreadable in the light theme: the title is pure white and the author and status lines are #bfcad6, all on a #f8f8f8 card. Measured contrast is 1.06:1 for the title - effectively invisible - and 1.57:1 for the other two. These sit on the card surface rather than over the cover art, so they now use the existing --text-color and --text-muted tokens, which base.css already defines for both schemes. Scoped deliberately. A contrast audit of the rendered page found these three rules and nothing else: the identically named .series-bottom-title in AudiobooksView sits on a rgb(26, 26, 26) placard where light text is correct, and the other hardcoded #fff and #bfcad6 values in both files are on dark overlays or coloured badges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With item details toggled on (the ⓘ toolbar button), the text under each cover is unreadable in the light theme.
Measured on the rendered page:
#f8f8f8.series-bottom-title#fff.series-bottom-author#bfcad6.series-bottom-meta#bfcad6These sit on the card surface, not over the cover art, so they now use the existing
--text-color/--text-mutedtokens thatbase.cssalready defines for both schemes.Deliberately scoped to three rules. A contrast audit over the rendered page flagged exactly these and nothing else. In particular the identically named
.series-bottom-titleinAudiobooksViewsits on argb(26,26,26)placard where light text is correct, so it is left alone — the other hardcoded#fff/#bfcad6values in both files are on dark overlays or coloured badges.