Skip to content

Issue with HOC section of course #2

Description

@kalmanh

Issue Overview

Hardcoding resource path inside UserInfoForm makes it pretty much unusable

Describe your environment

Branch 04_06e - https://github.com/LinkedInLearning/react-design-patterns-2895130/blob/04_06e/src/UserInfoForm.js UserInfoForm component has resource path and resource name hardcoded inside! This makes it impossible to specify a user in the App component.

Possible Solution

Why not specify resourcePath and resourceName in the JSX as a property to UserInfoForm???!!! https://github.com/kalmanh/react-design-patterns-2895130/tree/04_06_kalman

https://github.com/kalmanh/react-design-patterns-2895130/blob/04_06_kalman/src/withEditableResource.js#L6-L8

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions