feat: Nextcloud 35 compatibility - add nextcloud/ocp dependency - #21
Open
henmohr wants to merge 3 commits into
Open
feat: Nextcloud 35 compatibility - add nextcloud/ocp dependency#21henmohr wants to merge 3 commits into
henmohr wants to merge 3 commits into
Conversation
- Add nextcloud/ocp to require-dev for proper OCP type checking - Add OCP autoload path for static analysis The app already declared max-version=35 in info.xml and uses only public OCP interfaces (ABackend, ICheckPasswordBackend, IGetRealUIDBackend, IProvideEnabledStateBackend) which remain stable in NC35. Signed-off-by: henmohr <henmohr@users.noreply.github.com>
Regenerated composer.lock to include the nextcloud/ocp dev package added in the previous commit. Signed-off-by: henmohr <henmohr@users.noreply.github.com>
Remove nextcloud/ocp from require-dev since the psalm CI workflow already installs it dynamically with --ignore-platform-reqs. Restoring original composer.lock to fix composer validate --strict. Signed-off-by: henmohr <henmohr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
nextcloud/ocptorequire-devfor proper OCP type checking against the Nextcloud APIautoload-devfor static analysis toolsContext
The
info.xmlalready declaredmax-version="35"and the app uses only public OCP interfaces that remain stable in NC35:OCP\User\Backend\ABackendOCP\User\Backend\ICheckPasswordBackendOCP\User\Backend\IGetRealUIDBackendOCP\User\Backend\IProvideEnabledStateBackendOCP\Cache\CappedMemoryCacheAdding
nextcloud/ocpas a dev dependency ensures proper type checking and IDE support when developing against the NC35 API.CI
The existing CI workflows already test with PHP 8.2 and 8.3, covering NC35's PHP 8.3 requirement.