feat: explain when signer has no visible signature field - #8373
Merged
vitormattos merged 3 commits intoSep 13, 2026
Conversation
Signed-off-by: Maximilian Mayer <office@maximilianmayer.at>
Signed-off-by: Maximilian Mayer <office@maximilianmayer.at>
vitormattos
requested changes
Sep 12, 2026
Signed-off-by: Maximilian Mayer <office@maximilianmayer.at>
|
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 220 files with indirect coverage changes 🚀 New features to boost your workflow:
|
vitormattos
approved these changes
Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #8325
📝 Summary
Shows an NcNoteCard in the signing sidebar when the current signer has no visible signature field, so the page does not look incomplete.
Reuses hasVisibleElementsForCurrentUser(). I could not reuse needCreateSignature, it also returns false when the instance disallows creating signatures or when the user already has one.
The card is a sibling of the existing v-if chain, not part of it, so "Sign document" stays available.
🧪 How to test
🎨 UI / Front-end changes
Tests: component tests for both cases in Sign.spec.ts, and extended sign-herself-with-click-to-sign which already signs without a visible field.
One thing worth your review: the card also shows while a non-retriable certificate error blocks signing, so "Sign.vue - API error handling" now expects 2 note cards instead of 1. The issue describes the condition without exceptions so I kept it, but tell me if you want it hidden there.
✅ Checklist
🤖 AI (if applicable)