[stable33] feat: update JSignPdf to 3.1.0 with jsignpdf-php 3.0.0 - #8258
Merged
Conversation
JSignPdf 3.1 dropped the single JSignPdf.jar. The minimal package, meant for headless use, ships a lib/ directory that the wrapper starts through the classpath, so the configured path becomes the extracted directory, stored in the new jsignpdf_path key. The legacy jsignpdf_jar_path key is removed on install and on uninstall, and the archive is verified against the SHA256SUMS file published with the release instead of a hard-coded md5. The release metadata lives in JSignPdfRelease so it can be unit tested; SignSetupService and the setup check read the new key. Signed-off-by: André Maia <andrefnkmm@gmail.com> Assisted-by: Claude Code:claude-fable-5-1
…wrapper jsignpdf-php 3 escapes every argument itself and takes the options as a list, so the handler stops building shell syntax: the parameters are arrays, one cloned JSignParam per visible element, the signature text is passed as is instead of quoted, the JVM option and the JSIGNPDF_HOME variable go through their own setters, and the TSA password goes through setTsaPassword(), which the wrapper writes to the stdin of JSignPdf instead of the command line. The wrapper also renamed the jar path to a directory path and reports failures through the exit code. The tests assert the parameters that reach the wrapper, captured from setParam(), with structured providers, a case with shell special characters in the signature text and a TSA provider that checks the password never reaches the command line. Signed-off-by: André Maia <andrefnkmm@gmail.com> Assisted-by: Claude Code:claude-fable-5-1
…ertificate generateRootCert() resolves the CRL distribution point from the CA identifier. Without one the certificate generation failed and 68 tests of this class were skipped as "Certificate initialization failed". Signed-off-by: André Maia <andrefnkmm@gmail.com> Assisted-by: Claude Code:claude-fable-5-1
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
fix: update PDF signature validation return type Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> [skip ci]
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8256
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.