Conversation
-replaced manual is_same with is_host_fp_v -unified other HOST_HALF type conditions -removed unnecessary is_host_atomic_fp_v -removed duplications and dead code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2142
Cleanup corrections:
-replaced manual
is_samewithis_host_fp_v-unified other
HOST_HALFtype conditions-removed unnecessary
is_host_atomic_fp_v-removed duplications and dead code
Fixes:
-
CBasicTestFetchMinSpecialFloats:CL_FP_INF_NANchecked againstgDoubleAtomicCapsinstead ofgDoubleFPConfig-
CBasicTestFetchSub:VerifyRefsapplied to float only instead of all fp types-uninitialized programLine read in host-only debug mode
-half values printed as raw bits in error logs