Conversation
svenvh
force-pushed
the
commonfns-zero
branch
from
September 10, 2026 13:45
e8cb54c to
f8ef9ef
Compare
rjodinchr
reviewed
Sep 10, 2026
Positive and negative zero compare equal in C++, which allowed results of 0 with the wrong sign to pass. Fix with sign-aware comparisons. Also fix smoothstep diagnostics to report arguments in the official function signature order. This is preparatory work for improving the test's input ranges. [run-test: test_commonfns] Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
svenvh
force-pushed
the
commonfns-zero
branch
from
September 10, 2026 14:59
f8ef9ef to
4416aaa
Compare
rjodinchr
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Positive and negative zero compare equal in C++, which allowed results of 0 with the wrong sign to pass. Fix with sign-aware comparisons.
Also fix smoothstep diagnostics to report arguments in the official function signature order.
This is preparatory work for improving the test's input ranges.
[run-test: test_commonfns]