Fix test_vulkan_interop_image descriptor/command-buffer reuse hazard in useSingleImageKernel path - #2805
Open
shajder wants to merge 2 commits into
Open
Fix test_vulkan_interop_image descriptor/command-buffer reuse hazard in useSingleImageKernel path#2805shajder wants to merge 2 commits into
shajder wants to merge 2 commits into
Conversation
…in useSingleImageKernel path
rjodinchr
reviewed
Sep 10, 2026
rjodinchr
left a comment
Collaborator
There was a problem hiding this comment.
Can you explain why we should use a VulkanFence and not just call waitIdle?
If we keep VulkanFence, I think we should use std::make_shared instead of new, and we could have something like that:
if (i2DIdx < vkImage2DList->size() - 1)
{
vkQueue.submit(...);
vkImageDispatchFence->wait();
vkImageDispatchFence->reset();
}
Contributor
Author
...
Done. |
rjodinchr
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2800
Environment: rusticl -> Zink -> Lavapipe (software), Mesa 26.3.0-devel, LLVM 17.0.6, VK_LAYER_KHRONOS_validation 1.4.313, Vulkan instance 1.4.358.
Fixes VUID-vkUpdateDescriptorSets-None-03047 and VUID-vkBeginCommandBuffer-commandBuffer-00049, only visible with options
--useSingleImageKernel --useValidationLayerstogether.vkDescriptorSetandvkCopyCommandBufferwere reused across the per-image loop inrun_test_with_one_queueandrun_test_with_two_queuewithout waiting for the previous iteration's dispatch to finish. Added a VulkanFence to synchronize reuse.