Conversation
rjodinchr
force-pushed
the
integer-ops
branch
2 times, most recently
from
September 9, 2026 12:56
e729257 to
b9b50f1
Compare
shajder
requested changes
Sep 10, 2026
Contributor
There was a problem hiding this comment.
This PR changes testing scope in two independent ways, first the per-type shift sizes are now cut differently by domain size (long -1, int -2, short -3, char down to exhaustive). Second, the 0..255 base sweep in InitIntSpecialValues is dropped unconditionally, not just in wimpy mode, so even a full conformance run loses that coverage with no way to opt back in.
rjodinchr
force-pushed
the
integer-ops
branch
from
September 10, 2026 13:30
cf808f7 to
94e4f7f
Compare
rjodinchr
force-pushed
the
integer-ops
branch
from
September 11, 2026 08:00
43e33d9 to
efd640d
Compare
This patch rationalizes the integer operations conformance tests by focusing on test data quality rather than raw random iteration quantity. By prioritizing high-value edge cases and removing redundant test suites, the overall workload is confidently reduced without sacrificing test integrity. Specific changes include: * Remove explicit `quick_*` test definitions and handle workload scaling dynamically using `gWimpyMode`. * Replace hardcoded static `specialCaseList` arrays with mathematically dense edge cases generated dynamically via `GetIntSpecialValues`. * Add `offset_limit` and `wimpy` parameters to `GetIntSpecialValues` to drastically prune the combinatorial tree of generated edge cases when fast/wimpy runs are requested. * Rewrite `char` and `uchar` initialization to use a deterministic sliding 16-bit window instead of random data, systematically guaranteeing complete coverage for 8-bit interactions. [run-test: test_integer_ops -w]
rjodinchr
force-pushed
the
integer-ops
branch
from
September 11, 2026 09:41
efd640d to
6daefc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch rationalizes the integer operations conformance tests by focusing on test data quality rather than raw random iteration quantity. By prioritizing high-value edge cases and removing redundant test suites, the overall workload is confidently reduced without sacrificing test integrity.
Specific changes include:
quick_*test definitions and handle workload scaling dynamically usinggWimpyMode.specialCaseListarrays with mathematically dense edge cases generated dynamically viaGetIntSpecialValues.offset_limitandwimpyparameters toGetIntSpecialValuesto drastically prune the combinatorial tree of generated edge cases when fast/wimpy runs are requested.charanducharinitialization to use a deterministic sliding 16-bit window instead of random data, systematically guaranteeing complete coverage for 8-bit interactions.