Conversation
The testing on PoCL is skipped currently, because PoCL does not advertise support for the SPV_KHR_non_semantic_info SPIR-V extension.
Contributor
Author
|
Marking as a draft - I still need to add 32-bit SPIR-V files. |
bashbaug
marked this pull request as draft
August 13, 2026 18:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds targeted SPIR-V testing for the SPV_KHR_non_semantic_info extension, and specifically for SPIR-V modules that declare unknown (bogus) non-semantic extended instruction sets.
The testing on PoCL is skipped right now because PoCL does not currently advertise support for the SPV_KHR_non_semantic_info extension (via SPIR-V queries).
Even if PoCL did advertise support for SPV_KHR_non_semantic_info, the test will currently fail, because the fix for unknown non-semantic extended instruction sets has not been back-ported to all of the release branches. This should be fixed shortly, though, see e.g.: KhronosGroup/SPIRV-LLVM-Translator#3958
[run-test: test_spirv_new extinstimport_nonsemantic]