KC-1393: Fix pam rbi edit so NSF RBI settings persist via update_pam_record - #2283
Merged
Conversation
sshrushanth-ks
marked this pull request as ready for review
August 11, 2026 11:18
sshrushanth-ks
requested review from
amangalampalli-ks,
pvagare-ks and
sali-ks
August 11, 2026 11:42
amangalampalli-ks
approved these changes
Aug 11, 2026
sali-ks
approved these changes
Aug 12, 2026
pvagare-ks
approved these changes
Aug 12, 2026
sshrushanth-ks
added a commit
that referenced
this pull request
Aug 13, 2026
…record (#2283) * Fix pam rbi edit so NSF RBI settings persist via update_pam_record * Add NSF rbi edit regression test and debug log for is_pam_nsf_record fallback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed
pam rbi editso field changes on NSFpamRemoteBrowserrecords persist. The command was updatingpamRemoteBrowserSettingsin memory, then saving with classicrecord_management.update_record(), which does not reliably write NSF record data.Changes
pam rbi editsave path toupdate_pam_record()so NSF records use the NSF v3 update API (same pattern aspam tunnel edit)update_pam_recordinstead of classicupdate_record/sync_down