debug: print warning about NaN values in ym when direct=false#405
Merged
Conversation
The Kalman filters and `Luenberger` observer was not printing the `NaN` warning in `ym` when `direct=false`. This commit solve this.
franckgaga
changed the title
NaNs in ym warning when direct=falseNaN values in ym when direct=false
Member
Author
|
Merging, the tests all pass locally on my laptop. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 27 27
Lines 5722 5722
=======================================
Hits 5649 5649
Misses 73 73 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Kalman filters and
Luenbergerobserver were not printing theNaNwarning inymwhendirect=false. This PR is a bugfix and add tests to cover this specific case.