add some features for plotting describing functions#1043
Open
baggepinnen wants to merge 4 commits into
Open
Conversation
|
This is an automated message.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1043 +/- ##
==========================================
- Coverage 91.51% 91.50% -0.01%
==========================================
Files 42 42
Lines 5595 5723 +128
==========================================
+ Hits 5120 5237 +117
- Misses 475 486 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Correctness: - describing_function(sys::HammersteinWienerSystem) now computes the DF of the static callable when the nonlinearity is a Hysteresis, instead of dispatching to the analytical relay-with-hysteresis formula which describes the composite element realized by hysteresis(), not the static function the system applies. - describing_function_plot(sys::HammersteinWienerSystem) errors for systems whose external part is not SISO, and the docstring now states the open-loop unity-negative-feedback assumption (do not pass feedback(G*nl)). - Add promoting outer constructor Hysteresis(amplitude, width, hardness) so mixed numeric types work as documented. - Analytical describing_function overloads validate A > 0 like the generic numerical method, instead of silently returning a plausible value. - Fix docstring example output (the analytical Saturation DF is complex). - Docstring no longer claims exponential convergence of the trapezoidal rule unconditionally; document increasing N for discontinuous nonlinearities. - Restore direction-of-increasing-amplitude cues on the -1/N(A) curve (arrow and labeled endpoint markers) that the deleted example code had; hover only works with the plotly backend. Cleanup: - DeadZone DF computed via the exact identity N_dz(A) = 1 - N_sat(A), removing the duplicated formula and handling the asymmetric case exactly. - Name the numerical quadrature core describing_function_numerical and call it directly where analytical dispatch must be bypassed. - Remove commented-out dead code in the Hysteresis DF method. - Clarify the dual semantics of the Hysteresis struct (static callable vs analytical DF token) in its docstring. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.