Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The V7 backward-compatibility constants in
VirtualTrees.pas(e.g.ctNone = VirtualTrees.Types.TCheckType.ctNone) alias scoped enum members. Without telling the C++ header generator about that, C++Builder users encounter ambiguity compiler errors when these are translated to.hpp.This PR adds, for each constant in
VirtualTrees.pas:{$EXTERNALSYM}- stops the.hppgenerator from emitting a conflicting redeclaration for the symbol.{$HPPEMIT}- restores the plain, unscoped C++ aliasAdditional changes:
csMixedDisable->csMixedDisabled(typo - didn't match the enum member it was meant to alias).No runtime/behavior change - Delphi consumers are unaffected; this only fixes header generation for C++Builder.
Suggest any formatting changes if I didn't match the repository standards.