Fix: Improve accessibility of expand/collapse controls in Test Results view

[ZallaxDev]

Adjusted the language variable used for expand/collapse controls in the Test → Results → Detailed Results view to enhance accessibility and provide clearer, more consistent labeling.
This update ensures that assistive technologies can better interpret the purpose of the buttons.
Reference: Ticket #43953.

Additionally, we have included the modification in all languages and it has been specifically translated for:

• German
• French
• Japanese
• Swedish

[Chris-Squirrel]

'Fold out' is not correct English. 'Unfold' would be better in this case.

As this variable is a commons variable, are you sure that it is not used elsewhere? 'Expand content' is very general, whereas the new proposal is more specific - will it be correct in all usage scenarios?

[Annett7811]

@ZallaxDev: Thank you very much for your work. Could you please change the English language variable to “unfold”?

Thank you very much.
Annett

[dsstrassner]

This is still wrong, that a common language variable uses component-specific content.

common#:#expand_content#:#Unfold question and answer

And as far as I know, we do not add English content to anything other than ilias_en.lang - but @matthiaskunkel please correct me if I have a misinterpretation here.

[matthiaskunkel]

Thanks @ZallaxDev for this PR. But I have a question and at least one request:

It looks as if this language label is used in the UI component, right? In this case 'common' would be the correct language_module_ID. But if it only used in Test & Assessment it should be become assessment#:#expand_content#:...

It is very nice that you also changed other languages than English (and German), even for some with translation. But you do not need to do this. We have a script running from time to time that synchronises the English lang file with all others. But if make a change, then please update the timestamp after the entries. e.g. ###29 07 2022 new variable. This timestamp has to be substituted by a timestamp like '###4 12 2025 changed content' in case you made a translation or '###4 12 2025 new variable' if you only paste the English label into another language. Otherwise translators of these languages get confused.

Thanks and kind regards,
Matthias

[ZallaxDev]

Hello @Chris-Squirrel, @Annett7811, @dsstrassner and @matthiaskunkel:

Thank you very much for your time and feedback 😊

We have taken note of everything and will make the necessary corrections before rolling out the changes to the other versions of ILIAS.

I also appreciate the comments regarding the protocols for naming language variables. We have only been working with them directly on the platform for a short time, and this feedback is very valuable in helping us improve our procedures.

We will let you know as soon as the changes are ready.

Best regards,
Daniel.

[oliversamoila]

Hello everyone,
The change proposed here would result in a generic label for the glyphs in the presentation table. However, the label “Fold out question and answer” is not generic enough to be used for all presentation tables. We cannot do that.

@Annett7811 , What exactly is wrong with “Expand content” and “Collapse content”?
Or is it just the combination with “Show more” in the content area of a Presentation Table entry that you don't agree with?

I understand that the same functions should be described here with the same label. However, there is no “Show less” counterpart to “Show more.”
To be honest, I would also prefer to eliminate “Show more” from the content area of an entry altogether to prevent reports like this from occurring: https://mantis.ilias.de/view.php?id=36055 (in this case, my own, just a little while ago).
Or is there something else we should know about, @thibsy?

Therefore, I would say:
Step 1) Generic identifier
Step 2) Remove “Show more”

If you need to discuss this, feel free to do so here or in an external call.

Best regards,
@oliversamoila

[Annett7811]

Hello everyone!

@oliversamoila: Thanks for the clarification. I agree with the proposed approach and have no objections.
Using a generic identifier in common and avoiding component-specific wording makes sense to me, and I also support the idea of removing or unifying “Show more” for the sake of consistency and accessibility.

Thanks a lot for the discussion and the work on this.

Best regards
@Annett7811

[matthiaskunkel]

Hello, how we gonna proceed here? Any objections or missing feedback? Or can the PR be merged?

[oliversamoila]

Hello everyone,
@thibsy and I discussed this at the end of last week. I just didn't get around to posting the feedback yet.
We would like to completely remove the ‘Show more’ in the form of a shy button. This results in clear and predictable focus guidance – or rather, it allows us to create it.
@ZallaxDev, would you please remove this functional area and any associated code and update the PR accordingly? As a result, language adjustments are no longer necessary. Please request a review again once this has been done.

@Annett7811: just regarding Inio: Thibeau and I discussed that we should pay attention here to ensure that the collapse/expand function, which is also included in the title of the object, is not read aloud twice. But that's just a side note.

Best regards,
@oliversamoila (as UI Coordinator)

[abrahammordev]

Hi @oliversamoila,

We have submitted the commit that removes the “Show more” shy button from the form.

Could you please review the changes and let us know whether any additional adjustments or implementation steps are needed?

Best,
Abraham