-
Notifications
You must be signed in to change notification settings - Fork 12
Defer initial adInit until after React hydration on Next.js App Router #945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3ebcf8f
Defer initial adInit until after React hydration on Next.js App Router
aram356 4e79083
Merge branch 'main' into fix/react418-hydration-safety
aram356 adffdf6
Merge branch 'main' into fix/react418-hydration-safety
aram356 90a8922
Merge branch 'main' into fix/react418-hydration-safety
aram356 fb57a17
Merge branch 'main' into fix/react418-hydration-safety
aram356 6f9dbff
Guard deferred adInit with a navigation generation and make it testable
aram356 e3dab8f
Merge branch 'main' into fix/react418-hydration-safety
aram356 c3e8df3
Pin the initial adInit pass to generation 0 and restore the bundle fa…
aram356 a9f3cb3
Merge remote branch updates into fix/react418-hydration-safety
aram356 839f1e9
Merge branch 'main' into fix/react418-hydration-safety
prk-Jr 756cfaf
Document intended deferral tradeoffs and tighten review-round-three d…
aram356 fc14097
Merge branch 'main' into fix/react418-hydration-safety
aram356 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.