Rename the nodes 'Length' -> 'Magnitude', 'Flatten Path' -> 'Combine Paths', 'Vec2 Value' -> 'Combine Vec2', and add a new 'Vec2 Value' node#4349
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors and renames several nodes to improve consistency: it renames 'Flatten Path' to 'Combine Paths', renames 'Length' to 'Magnitude', and refactors 'Vec2 Value' to take a single vector input while introducing a new 'Combine Vec2' node for separate X and Y inputs. It also adds document migrations to ensure backward compatibility. The review feedback points out a critical issue in the migration path where the old active identifier for the 'Length' node (graphene_core::ops::LengthNode) was omitted from the aliases of the renamed 'Magnitude' node, which would break the loading of existing documents.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
All reported issues were addressed across 19 files
Confidence score: 5/5
- Safe to merge after the addressed issues were fixed.
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
No description provided.