Skip to content

Rename the nodes 'Length' -> 'Magnitude', 'Flatten Path' -> 'Combine Paths', 'Vec2 Value' -> 'Combine Vec2', and add a new 'Vec2 Value' node#4349

Merged
Keavon merged 4 commits into
masterfrom
rename-two-nodes
Jul 17, 2026
Merged

Rename the nodes 'Length' -> 'Magnitude', 'Flatten Path' -> 'Combine Paths', 'Vec2 Value' -> 'Combine Vec2', and add a new 'Vec2 Value' node#4349
Keavon merged 4 commits into
masterfrom
rename-two-nodes

Conversation

@Keavon

@Keavon Keavon commented Jul 17, 2026

Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors and renames several nodes to improve consistency: it renames 'Flatten Path' to 'Combine Paths', renames 'Length' to 'Magnitude', and refactors 'Vec2 Value' to take a single vector input while introducing a new 'Combine Vec2' node for separate X and Y inputs. It also adds document migrations to ensure backward compatibility. The review feedback points out a critical issue in the migration path where the old active identifier for the 'Length' node (graphene_core::ops::LengthNode) was omitted from the aliases of the renamed 'Magnitude' node, which would break the loading of existing documents.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread editor/src/messages/portfolio/document_migration.rs

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 19 files

Confidence score: 5/5

  • Safe to merge after the addressed issues were fixed.

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread node-graph/nodes/math/src/lib.rs
@Keavon
Keavon merged commit 0eab6aa into master Jul 17, 2026
11 checks passed
@Keavon
Keavon deleted the rename-two-nodes branch July 17, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant