Desktop: Stop compiling the editor into the wasm wrapper#4348
Conversation
|
!build desktop (Run ID 29549213219) |
There was a problem hiding this comment.
Code Review
This pull request refactors the communication layer between the editor backend and the frontend by introducing a new editor_commands macro to automatically generate JS-facing stubs, replacing ron serialization with serde_json and a custom WasmValue representation, and optimizing image data transfer using a new RasterizedImage struct. The review feedback highlights a critical bug in receive_native_message where a return statement inside a loop closure prematurely terminates the processing of the entire message batch; this should be replaced with continue. Additionally, a performance optimization is recommended in node_graph_executor.rs to pre-allocate the pixel buffer vector with exact capacity to avoid redundant reallocations during color conversion.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
Performance Benchmark Results
|
|
|
!build desktop (Run ID 29573812294) |
Performance Benchmark Results
|
15b3f40 to
33eb74f
Compare
Performance Benchmark Results
|
|
There was a problem hiding this comment.
All reported issues were addressed across 25 files
Confidence score: 5/5
- Safe to merge after the addressed issues were fixed.
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
Performance Benchmark Results
|
Performance Benchmark Results
|
|
Performance Benchmark Results
|
|
!build desktop (Run ID 29582074340) |
Performance Benchmark Results
|
|
|
|
Performance Benchmark Results
|
* Make wasm wrapper not depend on editor on native * Introduce pkg-native * Fix tests * Fix fmt * Correct span and make cargo fmt work inside editor_commands block * Review * Fix lint
No description provided.