Skip to content

fix(gae): Remove region tag gae_java8_datastore_property_filter due it is unused#10293

Merged
Kef131 merged 1 commit into
mainfrom
fix(gae)-freeze-gae-datastore-key
Jun 26, 2026
Merged

fix(gae): Remove region tag gae_java8_datastore_property_filter due it is unused#10293
Kef131 merged 1 commit into
mainfrom
fix(gae)-freeze-gae-datastore-key

Conversation

@Kef131

@Kef131 Kef131 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes #
b/348422798

Clean up unused region tag gae_java8_datastore_property_filter on appengine-java8/datastore/src/test/java/com/example/appengine/QueriesTest.java

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: appengine Issues related to the App Engine Admin API API. labels Jun 26, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the App Engine Datastore region tags (gae_java8_datastore_property_filter) from the QueriesTest.java file. There are no review comments, so I have no feedback to provide.

@Kef131 Kef131 marked this pull request as ready for review June 26, 2026 18:15
@Kef131 Kef131 requested review from a team and yoshi-approver as code owners June 26, 2026 18:15
@snippet-bot

snippet-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@amcolin amcolin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Kef131 Kef131 assigned Kef131 and unassigned YashBanka Jun 26, 2026
@Kef131 Kef131 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 26, 2026
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 26, 2026
@Kef131 Kef131 merged commit 116b2eb into main Jun 26, 2026
15 checks passed
@Kef131 Kef131 deleted the fix(gae)-freeze-gae-datastore-key branch June 26, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: appengine Issues related to the App Engine Admin API API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants