[INF-1722] Accept absent primary-key deletes during replay - #22
Merged
Conversation
darkoatanasovski
approved these changes
Aug 28, 2026
JimmyPettersson85
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://linear.app/stream/issue/INF-1722/migrate-dublinc3
Summary
Treat a source DELETE as a no-op when its catalog-validated primary key is already absent on the target. This unblocks replay without skipping the source transaction or resetting migration progress.
Only DELETE result validation changes. Malformed identities, duplicate/invalid result ordinals, excess matches, unsafe identities, SQL errors, and receipt/checkpoint guards remain errors. No configuration, SQL generation, claim format, acknowledgement, or UPDATE behavior changes.
Validation
go vet ./..., and complete CDC/application integration suites with the race detector pass; CI is green.Checklist
Rollout / risk
Image-only update followed by normal resume on the existing state directory, source slot and target checkpoint. No recopy, checkpoint skip, production source row writes, or cutover. An old binary can still open the unchanged state format, but may stop again on an absent DELETE. This does not authorize independent target traffic or prove absence of unrelated drift.