build: migrate effect v3 → v4 (beta.103) - #747
Conversation
Migrate all packages from effect@^3.20 to effect@4.0.0-beta.103. Key changes: - Replace Micro with Effect throughout oidc-client and davinci-client - Migrate Either to Result in sdk-utilities and journey-client - Migrate MicroExit/exitIsFail/exitIsSuccess to Exit/Cause API - Update e2e/mock-api-v2 from @effect/platform to effect/unstable/httpapi - Bump vitest catalog to ^4.1.0 to match @effect/vitest peer requirement - Remove consolidated packages: @effect/platform, @effect/cli - Fix handleMicroExit → handleExit (renamed) - Add vi.clearAllMocks() to oidc-client afterEach (accumulated mock counts)
|
|
Warning Review limit reached
Next review available in: 30 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR migrates the repository to Effect 4 APIs. It updates the mock HTTP API, client effects, Result handling, service declarations, HTTP clients, schemas, API reports, and package catalogs. ChangesMock HTTP API migration
Effect runtime migration
Tooling and HTTP client updates
Estimated code review effort: 4 (Complex) | ~60 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 02cb3c2
💡 Dealing with memory or CPU issues? See memory and CPU details with the resource usage add-on ↗. ☁️ Nx Cloud last updated this comment at |
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Effect.sleep in v4 beta.103 hangs in Vite-bundled browser environments due to ClockRef/withFiber/clockWith indirection chain. Replace with delayMs helper using Effect.callback + plain setTimeout to match v3 Micro.sleep behavior. Also fix: - pollStatus: use Effect.runPromiseExit(effect) direct call (not pipe) - pollStatus: add Cause.squash fallback for defect errors - password-policy.rules.ts: Result.failVoid → Result.fail(undefined)
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 9
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@e2e/mock-api-v2/src/main.ts`:
- Around line 39-42: Update the SessionLayer definition to use
Layer.provideMerge instead of Layer.provide, so SessionMiddlewareMock is
satisfied while SessionStorage remains exposed for EndSessionHandlerMock through
HandlersLayer and ServicesLayer.
- Around line 78-82: Update the HttpMiddleware.cors configuration to replace the
wildcard allowedOrigins value with the configured trusted localhost/test origin
list or predicate, while preserving credentials support and the existing
allowedMethods and maxAge settings.
In `@e2e/mock-api-v2/src/middleware/Authorization.ts`:
- Around line 35-37: Remove the raw credential value from the logging flow in
Authorization middleware: stop deriving or passing tokenValue from
Redacted.value(credential) to Effect.log, and retain only the non-sensitive
“checking bearer token” metadata for both valid and invalid requests.
In `@e2e/mock-api-v2/src/services/mock-env-helpers/index.ts`:
- Around line 66-72: Update validateCapabilitiesResponse to pass the request
body shape expected by validator, preserving the existing null validation as
appropriate; alternatively, change validator’s matching pattern to accept the
extracted formData.value shape, ensuring invalid credentials reach Match.orElse
and fail correctly.
In `@e2e/mock-api-v2/src/services/session.service.ts`:
- Line 19: Update refreshSession to expose Error failures instead of declaring
never failures, using the required Effect type with SessionData success and
Error failure channels. In its Effect.fn implementation, yield failed effects so
missing or expired sessions propagate as failures, and return the refreshed
session only on success.
In `@packages/davinci-client/src/lib/client.store.effects.ts`:
- Around line 256-281: Document that pollRetries represents total polling
attempts because doPoll executes once before the loop, with values 0 and 1 both
producing only the initial poll; add boundary tests covering 0, 1, and 2 using
the polling function and existing test setup. If the intended contract is
retries after the initial attempt instead, rename the configuration and adjust
the loop semantics consistently.
In `@packages/oidc-client/src/lib/authorize.request.utils.test.ts`:
- Around line 140-143: Replace the early returns after Cause.findErrorOption in
all listed sites with assertions that errorOpt is Some, then abort before
accessing errorOpt.value when the assertion fails. Apply this to
authorize.request.utils.test.ts ranges 140-143, 187-190, 211-214, and 290-293;
logout.request.test.ts ranges 213-216, 251-254, 321-324, and 360-363; and
authorize.request.micros.test.ts ranges 81-84, 110-113, 145-148, 199-202,
229-232, 240-243, 282-285, 307-310, 334-337, 378-381, 419-422, and 441-444,
preserving the subsequent typed-error validation.
In `@packages/oidc-client/src/lib/session.micros.test.ts`:
- Around line 204-208: Update each failure assertion block in the session tests,
including the blocks using Cause.findErrorOption, to assert
Option.isSome(errorOpt) before the early-return guard. Keep the existing
typed-error value assertions, but ensure a missing error option fails the test
rather than allowing the guard to pass.
In `@tools/user-scripts/src/lib/user-scripts.ts`:
- Around line 96-98: Enable or add active tests in user-scripts.test.ts covering
deleteUser with configuration-provided success behavior and HttpClientError
conversion to DeleteUserError. Keep the tests uncommented and assert both the
successful result and the mapped error outcome.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 3bf9e131-5861-45d4-9990-1a2fd9280d3a
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (58)
e2e/mock-api-v2/package.jsone2e/mock-api-v2/src/handlers/authorize.handler.tse2e/mock-api-v2/src/handlers/capabilities.handler.tse2e/mock-api-v2/src/handlers/end-session.handler.tse2e/mock-api-v2/src/handlers/healthcheck.handler.tse2e/mock-api-v2/src/handlers/open-id-configuration.handler.tse2e/mock-api-v2/src/handlers/revoke.handler.tse2e/mock-api-v2/src/handlers/token.handler.tse2e/mock-api-v2/src/handlers/userinfo.handler.tse2e/mock-api-v2/src/helpers/match.tse2e/mock-api-v2/src/main.tse2e/mock-api-v2/src/middleware/Authorization.tse2e/mock-api-v2/src/middleware/CookieMiddleware.tse2e/mock-api-v2/src/middleware/Session.tse2e/mock-api-v2/src/schemas/authorize.schema.tse2e/mock-api-v2/src/schemas/capabilities/capabilities.request.schema.tse2e/mock-api-v2/src/schemas/capabilities/capabilities.response.schema.tse2e/mock-api-v2/src/schemas/open-id-configuration/open-id-configuration-response.schema.tse2e/mock-api-v2/src/schemas/return-success-response-redirect.schema.tse2e/mock-api-v2/src/schemas/revoke/revoke.schema.tse2e/mock-api-v2/src/schemas/token/token.schema.tse2e/mock-api-v2/src/services/mock-env-helpers/index.tse2e/mock-api-v2/src/services/session.service.tse2e/mock-api-v2/src/services/tokens.service.tse2e/mock-api-v2/src/services/userinfo.service.tse2e/mock-api-v2/src/spec.tspackage.jsonpackages/davinci-client/api-report/davinci-client.api.mdpackages/davinci-client/api-report/davinci-client.types.api.mdpackages/davinci-client/src/lib/client.store.effects.test.tspackages/davinci-client/src/lib/client.store.effects.tspackages/davinci-client/src/lib/client.store.tspackages/davinci-client/src/lib/fido/fido.tspackages/davinci-client/src/lib/password-policy.rules.tspackages/journey-client/src/lib/client.store.tspackages/journey-client/src/lib/journey.utils.test.tspackages/journey-client/src/lib/journey.utils.tspackages/oidc-client/src/lib/authorize.request.micros.test.tspackages/oidc-client/src/lib/authorize.request.micros.tspackages/oidc-client/src/lib/authorize.request.tspackages/oidc-client/src/lib/authorize.request.utils.test.tspackages/oidc-client/src/lib/client.store.tspackages/oidc-client/src/lib/exchange.request.tspackages/oidc-client/src/lib/exchange.utils.test.tspackages/oidc-client/src/lib/exchange.utils.tspackages/oidc-client/src/lib/logout.request.test.tspackages/oidc-client/src/lib/logout.request.tspackages/oidc-client/src/lib/session.micros.test.tspackages/oidc-client/src/lib/session.micros.tspackages/sdk-utilities/src/lib/config/config.effects.tspackages/sdk-utilities/src/lib/config/config.test.tspackages/sdk-utilities/src/lib/config/config.types.tspackages/sdk-utilities/src/lib/config/config.utils.tspackages/sdk-utilities/src/lib/micro.utils.tspnpm-workspace.yamltools/release/package.jsontools/user-scripts/package.jsontools/user-scripts/src/lib/user-scripts.ts
💤 Files with no reviewable changes (2)
- tools/user-scripts/package.json
- tools/release/package.json
| const SessionLayer = Layer.provide( | ||
| SessionMiddlewareMock, | ||
| Layer.effect(SessionStorage, SessionStorage.make), | ||
| ); |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
ast-grep outline e2e/mock-api-v2/src/main.ts --items all
rg -n -C 6 'SessionStorage|SessionLayer|Layer\.provide|Layer\.provideMerge|Layer\.launch' \
e2e/mock-api-v2/src/main.ts
rg -n -C 4 'yield\*\s+SessionStorage' \
e2e/mock-api-v2/src/handlers --glob '*.ts'Repository: ForgeRock/ping-javascript-sdk
Length of output: 5674
🌐 Web query:
effect 2.4 Layer.provideMerge Layer.provide outputs consumed semantics
💡 Result:
In Effect, Layer.provide and Layer.provideMerge are both combinators used for composing layers, but they differ in how they handle the resulting service environment [1][2][3]. Layer.provide Use Layer.provide when you want to satisfy a layer's internal dependencies using another layer without exposing those dependencies to the rest of the application [2][4]. Semantics: It wires the provided layer to satisfy the requirements of the base layer [4]. Once satisfied, those dependencies are "consumed" internally, meaning they are no longer available in the context of the resulting layer [2][4]. This is ideal for encapsulating implementation details [2]. Layer.provideMerge Use Layer.provideMerge when you want to satisfy a layer's dependencies while also keeping those dependencies available for use elsewhere in your program [4][3]. Semantics: It wires the provided layer to satisfy the requirements of the base layer, but crucially, it merges the output of the provided layer into the output of the resulting layer [2][3]. As a result, both the original services and the provided services remain accessible in the final context [4][3]. This is particularly common in testing scenarios where you need access to multiple services simultaneously [4]. Summary Comparison | Method | Deps Satisfied | Available to Program | Use When | |--------|---------------|---------------------|----------| | Layer.provide | Yes | No | Internal dependency satisfaction / Encapsulation [2][4] | | Layer.provideMerge | Yes | Yes | Exposing multiple services / Testing [4][3] | In essence, while both methods fulfill requirements, Layer.provide acts as a form of private dependency injection, whereas Layer.provideMerge acts as a union of available services [2][4][3].
Citations:
- 1: https://github.com/Effect-TS/effect-smol/blob/main/ai-docs/src/01_effect/02_services/20_layer-composition.ts
- 2: https://v2.alchemy.run/concepts/layers/
- 3: https://www.ayokoding.com/en/learn/software-engineering/platform-web/tools/ts-effect/by-example/intermediate
- 4: https://github.com/artimath/effect-skills/blob/main/skills/effectts/SKILL.md
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n "provideMerge|provide:" node_modules effect 2>/dev/null || trueRepository: ForgeRock/ping-javascript-sdk
Length of output: 167
Expose SessionStorage from SessionLayer.
Layer.provide satisfies SessionMiddlewareMock and consumes the SessionStorage output, so HandlersLayer → ServicesLayer has no provider for yield* SessionStorage in EndSessionHandlerMock. Use Layer.provideMerge here to satisfy the middleware and keep SessionStorage available to handlers.
Proposed fix
-const SessionLayer = Layer.provide(
+const SessionLayer = Layer.provideMerge(
SessionMiddlewareMock,
Layer.effect(SessionStorage, SessionStorage.make),
);📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const SessionLayer = Layer.provide( | |
| SessionMiddlewareMock, | |
| Layer.effect(SessionStorage, SessionStorage.make), | |
| ); | |
| const SessionLayer = Layer.provideMerge( | |
| SessionMiddlewareMock, | |
| Layer.effect(SessionStorage, SessionStorage.make), | |
| ); |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@e2e/mock-api-v2/src/main.ts` around lines 39 - 42, Update the SessionLayer
definition to use Layer.provideMerge instead of Layer.provide, so
SessionMiddlewareMock is satisfied while SessionStorage remains exposed for
EndSessionHandlerMock through HandlersLayer and ServicesLayer.
| HttpMiddleware.cors({ | ||
| allowedMethods: ['GET', 'PUT', 'POST', 'OPTIONS'], | ||
| allowedOrigins: ['*'], | ||
| credentials: true, | ||
| maxAge: 3600, |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🌐 Web query:
In effect@4.0.0-beta.103, does HttpMiddleware.cors({ allowedOrigins: [""] })match arbitrary origins or only an Origin header equal to? Cite the source implementation or API reference.
💡 Result:
In Effect 4.0.0-beta.103, providing allowedOrigins: ["*"] in HttpMiddleware.cors() does not restrict access to origins that literally equal the string * [1][2]. Instead, the implementation treats this as a specific configuration that allows the asterisk character, which browsers interpret as a wildcard allowing all origins [1][2]. According to the official implementation and documentation, allowedOrigins can be an array of strings, a predicate function, or empty (which defaults to allowing all origins) [1][2]. If you provide ["*"], the middleware includes this in the Access-Control-Allow-Origin header for incoming requests, effectively enabling a wildcard CORS policy [3]. Source Implementation API Reference: The relevant implementation is found in the Effect Platform package's HttpMiddleware.ts file [1][2]. The cors constructor handles allowedOrigins by validating the incoming Origin header against the provided configuration (either by checking if the origin is included in the array or by executing the provided predicate) [1][3]. Relevant documentation excerpt from source: @param options.allowedOrigins - Origins allowed to access the resource. Can be: - An array of origin strings (e.g., ["https://example.com", "https://api.example.com"]) - A predicate function to dynamically allow origins - If empty array (default): allows all origins with Access-Control-Allow-Origin: * [1][2]
Citations:
- 1: https://github.com/Effect-TS/effect/blob/70ce155c/packages/platform/src/HttpMiddleware.ts
- 2: https://github.com/Effect-TS/effect/blob/4708bb8e/packages/platform/src/HttpMiddleware.ts
- 3: https://github.com/Effect-TS/effect/blob/2e9a34ac/packages/effect/src/unstable/http/HttpMiddleware.ts
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Locate the affected file and inspect package versions / HttpMiddleware.cors usage.
printf 'Files:\n'
git ls-files | rg '(^|/)package.json$|e2e/mock-api-v2/src/main.ts|HttpMiddleware' || true
printf '\nAffected file context:\n'
sed -n '1,140p' e2e/mock-api-v2/src/main.ts
printf '\nRoot/package effect versions:\n'
node - <<'JS'
const fs = require('fs');
for (const p of ['package.json','package-lock.json','pnpm-lock.yaml','yarn.lock']) {
if (fs.existsSync(p)) {
console.log(`\n--- ${p} ---`);
const s = fs.readFileSync(p, 'utf8');
if (p.endsWith('.json')) {
const j = JSON.parse(s);
if (j.dependencies?.effect || j.devDependencies?.effect || j.dependencies?.'`@effect/platform`' || j.devDependencies?.'`@effect/platform`') {
console.log(JSON.stringify({deps:j.dependencies, devDeps:j.devDependencies}, null, 2).slice(0, 2000));
}
} else {
for (const m of ['effect','`@effect/platform`']) {
const idx = s.indexOf(m + '@');
console.log(m, idx >= 0 ? s.slice(idx, idx + 200) : 'not found');
}
}
}
}
JS
printf '\nLockfile effect platform refs:\n'
rg -n '"?effect( |-|@)?/?platform"?|effect@.*4\.0\.0-beta\.103|HttpMiddleware\.cors|allowedOrigins' package* e2e -S || trueRepository: ForgeRock/ping-javascript-sdk
Length of output: 5774
🏁 Script executed:
#!/bin/bash
set -fu
printf 'Root/package effect version references:\n'
rg -n --no-heading '"?effect( |-|@)?/?platform"?|`@effect/platform`|effect@|HttpMiddleware\.cors|allowedOrigins' package.json e2e/mock-api-v2/package.json packages/*/package.json e2e/*/package.json -S || true
printf '\nPackage json versions if present:\n'
node - <<'JS'
const fs = require('fs');
const files = ['package.json','e2e/mock-api-v2/package.json'];
for (const f of files) {
if (!fs.existsSync(f)) continue;
const j = JSON.parse(fs.readFileSync(f, 'utf8'));
console.log(`\n--- ${f} ---`);
console.log(JSON.stringify({ dependencies: j.dependencies, devDependencies: j.devDependencies }, null, 2));
}
JS
printf '\nSource availability check for effect package files:\n'
for d in node_modules/effect node_modules/@effect/platform node_modules/cache?; do
if [ -d "$d" ]; then echo "$d"; find "$d" -maxdepth 2 -type f | head -30; fi
doneRepository: ForgeRock/ping-javascript-sdk
Length of output: 3404
🌐 Web query:
Effect.ts unstable HttpMiddleware allowedOrigins "*" Origin header exact match
💡 Result:
In Effect.ts, the HttpMiddleware.cors implementation handles the allowedOrigins configuration by performing an exact match when an array of strings is provided [1][2]. Specifically, the middleware logic determines whether to allow an incoming Origin header based on the allowedOrigins option [1][2]: 1. If allowedOrigins is a ReadonlyArray<string>, the middleware checks if the incoming Origin header is included in that array [1][2]. 2. When the array contains exactly one origin, the middleware sets the Access-Control-Allow-Origin header to that specific origin [1][2]. 3. When the array contains multiple origins, or when a predicate function is provided, the middleware dynamically checks the Origin header and, if matched, reflects it back in the Access-Control-Allow-Origin header along with a Vary: Origin header [1][2]. 4. If allowedOrigins is not provided (or is an empty array), the middleware defaults to allowing all origins by setting Access-Control-Allow-Origin: * [3][1][2]. The use of Array.prototype.includes ensures that the comparison against the provided list of origins is an exact string match [1][2]. If you require more flexible matching (e.g., regex or suffix matching), you should provide a predicate function to the allowedOrigins option instead [3][4][5].
Citations:
- 1: https://github.com/Effect-TS/effect/blob/70ce155c/packages/platform/src/internal/httpMiddleware.ts
- 2: https://github.com/Effect-TS/effect/blob/2e9a34ac/packages/effect/src/unstable/http/HttpMiddleware.ts
- 3: https://github.com/Effect-TS/effect/blob/70ce155c/packages/platform/src/HttpMiddleware.ts
- 4: https://effect-ts.github.io/effect/platform/HttpMiddleware.ts.html
- 5: https://github.com/Effect-TS/effect/blob/4708bb8e/packages/platform/src/HttpMiddleware.ts
🌐 Web query:
Effect.ts HttpMiddleware coredocs CORS allowedOrigins asterisk browser Origin header literal "*"
💡 Result:
In the Effect.ts platform library, the CORS middleware is configured via HttpMiddleware.cors [1][2]. According to the official documentation, if the allowedOrigins option is left as an empty array (which is the default behavior), the middleware will allow all origins by setting the Access-Control-Allow-Origin response header to the wildcard value * [2][3]. Regarding the browser's handling of the wildcard * in the Origin header or CORS response: 1. Functionality: The Access-Control-Allow-Origin: * header instructs the browser that any origin may access the resource, provided the request does not include credentials (such as cookies, authorization headers, or TLS client certificates) [4][5]. 2. Credentials Constraint: If a request includes credentials, the browser will block the response if the server returns Access-Control-Allow-Origin: * [5][6]. In such cases, the server must instead specify an explicit, single origin (e.g., Access-Control-Allow-Origin: https://example.com) [4][5][7]. 3. Security: Using the * wildcard is appropriate only for public, non-credentialed resources [8][6]. If your application requires credentialed access, you must configure allowedOrigins to a specific list or a predicate function to dynamically validate the Origin request header against your allowlist [1][2][5]. When using a dynamic predicate for allowedOrigins in Effect.ts, it is recommended practice to include the Vary: Origin response header to inform browsers that the response depends on the Origin request header [4][5].
Citations:
- 1: https://effect-ts.github.io/effect/platform/HttpMiddleware.ts.html
- 2: https://github.com/Effect-TS/effect/blob/70ce155c/packages/platform/src/HttpMiddleware.ts
- 3: https://github.com/Effect-TS/effect/blob/4708bb8e/packages/platform/src/HttpMiddleware.ts
- 4: https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Access-Control-Allow-Origin
- 5: https://developer.mozilla.org/en-US/docs/Web/HTTP/Guides/CORS
- 6: https://owasp.org/www-project-web-security-testing-guide/latest/4-Web_Application_Security_Testing/11-Client-side_Testing/07-Testing_Cross_Origin_Resource_Sharing
- 7: https://web.dev/articles/cross-origin-resource-sharing
- 8: https://developer.mozilla.org/en-US/docs/Web/Security/Practical_implementation_guides/CORS
Configure trusted localhost origins instead of ['*'].
allowedOrigins: ['*'] only matches requests whose Origin header is literal *, so browser origins such as Vite development origins will not receive Access-Control-Allow-Origin. This disables browser CORS access when credentials: true. Use a configured test origin list or predicate instead.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@e2e/mock-api-v2/src/main.ts` around lines 78 - 82, Update the
HttpMiddleware.cors configuration to replace the wildcard allowedOrigins value
with the configured trusted localhost/test origin list or predicate, while
preserving credentials support and the existing allowedMethods and maxAge
settings.
| Effect.gen(function* () { | ||
| const tokenValue = Redacted.value(bearerToken); | ||
| const tokenValue = Redacted.value(credential); | ||
| yield* Effect.log('checking bearer token', tokenValue); |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
Do not log the raw bearer token.
Redacted.value(credential) exposes the credential. Line 37 then writes it to logs for valid and invalid requests. Remove tokenValue from this log entry. Log only non-sensitive metadata.
Proposed fix
- yield* Effect.log('checking bearer token', tokenValue);
+ yield* Effect.log('checking bearer token');🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@e2e/mock-api-v2/src/middleware/Authorization.ts` around lines 35 - 37, Remove
the raw credential value from the logging flow in Authorization middleware: stop
deriving or passing tokenValue from Redacted.value(credential) to Effect.log,
and retain only the non-sensitive “checking bearer token” metadata for both
valid and invalid requests.
| const validateCapabilitiesResponse = (body: any) => | ||
| pipe( | ||
| body, | ||
| Option.fromNullable, | ||
| Option.map((body) => body.parameters), | ||
| Option.map((parameters) => parameters.data), | ||
| Option.map((data) => data.formData), | ||
| Option.map((formData) => formData.value), | ||
| Effect.flatMap(validator), | ||
| ); | ||
| Effect.gen(function* () { | ||
| if (body == null) return yield* Effect.fail(new HttpApiError.InternalServerError()); | ||
| const value = body?.parameters?.data?.formData?.value; | ||
| if (value == null) return yield* Effect.fail(new HttpApiError.InternalServerError()); | ||
| return yield* validator(value); | ||
| }); |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Pass the request body shape that validator matches.
Line 69 extracts formData.value, but validator matches the outer parameters.data.formData.username and parameters.data.formData.password structure. The match falls through to Match.orElse, so invalid credentials succeed.
Pass body to validator, or change validator to match the extracted value shape.
Proposed fix
const validateCapabilitiesResponse = (body: any) =>
Effect.gen(function* () {
if (body == null) return yield* Effect.fail(new HttpApiError.InternalServerError());
- const value = body?.parameters?.data?.formData?.value;
- if (value == null) return yield* Effect.fail(new HttpApiError.InternalServerError());
- return yield* validator(value);
+ if (body?.parameters?.data?.formData == null) {
+ return yield* Effect.fail(new HttpApiError.InternalServerError());
+ }
+ return yield* validator(body);
});📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const validateCapabilitiesResponse = (body: any) => | |
| pipe( | |
| body, | |
| Option.fromNullable, | |
| Option.map((body) => body.parameters), | |
| Option.map((parameters) => parameters.data), | |
| Option.map((data) => data.formData), | |
| Option.map((formData) => formData.value), | |
| Effect.flatMap(validator), | |
| ); | |
| Effect.gen(function* () { | |
| if (body == null) return yield* Effect.fail(new HttpApiError.InternalServerError()); | |
| const value = body?.parameters?.data?.formData?.value; | |
| if (value == null) return yield* Effect.fail(new HttpApiError.InternalServerError()); | |
| return yield* validator(value); | |
| }); | |
| const validateCapabilitiesResponse = (body: any) => | |
| Effect.gen(function* () { | |
| if (body == null) return yield* Effect.fail(new HttpApiError.InternalServerError()); | |
| if (body?.parameters?.data?.formData == null) { | |
| return yield* Effect.fail(new HttpApiError.InternalServerError()); | |
| } | |
| return yield* validator(body); | |
| }); |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@e2e/mock-api-v2/src/services/mock-env-helpers/index.ts` around lines 66 - 72,
Update validateCapabilitiesResponse to pass the request body shape expected by
validator, preserving the existing null validation as appropriate;
alternatively, change validator’s matching pattern to accept the extracted
formData.value shape, ensuring invalid credentials reach Match.orElse and fail
correctly.
| sessionId: string, | ||
| data: SessionData, | ||
| ) => Effect.Effect<SessionData | Error, never, never>; | ||
| refreshSession: (sessionId: string, expiryDate?: Date) => Effect.Effect<unknown, never, never>; |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n -C 5 'refreshSession\s*:|refreshSession\s*\(' e2e/mock-api-v2/src
rg -n -C 5 'return\s+Effect\.fail|return\s+new Error' e2e/mock-api-v2/src/services/session.service.tsRepository: ForgeRock/ping-javascript-sdk
Length of output: 3893
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== session service relevant lines =="
cat -n e2e/mock-api-v2/src/services/session.service.ts | sed -n '1,115p'
echo
echo "== Session middleware relevant lines =="
cat -n e2e/mock-api-v2/src/middleware/Session.ts | sed -n '1,90p'
echo
echo "== package effect version =="
for f in package.json e2e/mock-api-v2/package.json; do
if [ -f "$f" ]; then
echo "--- $f ---"
jq '.dependencies.effect // .devDependencies.effect // empty' "$f"
fi
done
echo
echo "== lockfile effect entries (focused) =="
for f in pnpm-lock.yaml package-lock.json yarn.lock; do
if [ -f "$f" ]; then
echo "--- $f ---"
rg -n '"?effect"?|version:.*effect|/effect@' "$f" | head -80
fi
doneRepository: ForgeRock/ping-javascript-sdk
Length of output: 10513
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== pnpm catalog/depecks declarations =="
rg -n -C 3 'catalog:|effect:|catalog' package.json pnpm-workspace.yaml pnpm-lock.yaml | sed -n '1,120p'
echo
echo "== lockfile effect 4 version record =="
rg -n -C 5 'effect@4\.0\.0-beta\.103' pnpm-lock.yaml
echo
echo "== installed effect package metadata if present =="
node - <<'JS'
const fs = require('fs');
const paths = ['e2e/mock-api-v2/node_modules/effect/package.json','node_modules/effect/package.json','packages/sdk-effects/node_modules/effect/package.json'];
for (const path of paths) {
if (fs.existsSync(path)) {
const pkg = JSON.parse(fs.readFileSync(path,'utf8'));
console.log(path, {version(pkg),main(pkg),types: pkg.types});
break;
}
}
console.log('installed_effect=' + paths.find(p => fs.existsSync(p) || ''));
JSRepository: ForgeRock/ping-javascript-sdk
Length of output: 13361
🌐 Web query:
Effect v4 4.0.0-beta.103 Effect.fn generator return Effect fail yield* nested Effect warning
💡 Result:
The warning you are encountering regarding nested Effect.gen calls is triggered by the nestedEffectGenYield diagnostic provided by the @effect/language-service package [1][2][3]. This diagnostic is designed to warn developers when they yield a bare Effect.gen inside an existing Effect generator context [2]. The rationale for this warning is that such nested generators can typically be inlined directly into the parent Effect generator, which simplifies the code and improves readability [2]. If you are seeing this warning in a context where you believe it is unnecessary (e.g., in certain single-return patterns), note that recent updates have addressed false positives [4]. Specifically, pull request #746 in the @effect/language-service repository avoids reporting the unnecessaryEffectGen warning when the yielded expression contains a nested yield* [4]. Key points regarding this diagnostic: - It is identified as nestedEffectGenYield [1][2]. - It is supported for both Effect v3 and v4 [2]. - Its default severity is set to off in some configurations, meaning you can choose to enable or disable it based on your project's coding standards [2][5]. - You can find documentation on how to configure or disable specific diagnostics in the @effect/language-service documentation [5][6]. If your current environment (using 4.0.0-beta.103) is reporting this and you find it disruptive, ensure your @effect/language-service package is updated to the latest version that includes the fix for false positives [4][3].
Citations:
- 1: Effect-TS/language-service@4229bb9
- 2: Effect-TS/tsgo@086dff3
- 3: https://github.com/Effect-TS/language-service/releases
- 4: Fix unnecessary Effect.gen nested yield false positive Effect-TS/language-service#746
- 5: https://github.com/Effect-TS/tsgo/blob/main/README.md
- 6: https://github.com/Effect-TS/language-service/blob/main/README.md
🌐 Web query:
effect 4.0.0-beta.103 Effect.orDie documentation
💡 Result:
In Effect 4.0.0-beta.103, Effect.orDie is a function used to convert an effect's expected error into an unrecoverable defect, effectively removing the error from the effect's type [1]. When applied, any failure that occurs within that effect will cause the fiber to terminate [1]. Key aspects of Effect.orDie: - Purpose: It is intended for scenarios where an error is considered unrecoverable and you do not wish to perform error handling within the effect pipeline [1]. - Type transformation: It changes an Effect<A, E, R> into an Effect<A, never, R> [1]. - Behavior: By converting the failure into a defect (fiber termination), it simplifies types for cases where you prefer failures to bubble up rather than being handled locally [1][2]. Usage note: In the transition to Effect v4, some associated utility functions have changed. For example, Effect.orDieWith has been removed; it is recommended to use a combination of Effect.mapError and Effect.orDie instead [3]: myEffect.pipe( Effect.mapError(e => new Error(Failed: ${e})), Effect.orDie); This function is also available within the Micro module (Micro.orDie), which follows the same principle of elevating expected errors to unexpected ones [4][5].
Citations:
- 1: https://effect.website/docs/error-management/unexpected-errors/
- 2: https://www.answeroverflow.com/m/1218171204645552180
- 3: Migration documentation missing for many removed/renamed functions and types Effect-TS/effect#6379
- 4: https://effect-ts.github.io/effect/effect/Micro.ts.html
- 5: https://effect.website/docs/micro/new-users/
Restore refreshSession failure propagation.
refreshSession declares never failures, but the implementation hides refresh failures with successful values. Effect.fail(...) and new Error(...) inside Effect.fn are returned as success values unless yielded/frowned as the failed Effect. Callers then treat missing/expired sessions as successful refreshes and use Effect.orDie on the wrong value.
Type failures with Effect.Effect<SessionData | SessionData | Error, Error, never>. Return failed refreshes with yield* Effect.fail(...). Return the refreshed session on success.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@e2e/mock-api-v2/src/services/session.service.ts` at line 19, Update
refreshSession to expose Error failures instead of declaring never failures,
using the required Effect type with SessionData success and Error failure
channels. In its Effect.fn implementation, yield failed effects so missing or
expired sessions propagate as failures, and return the refreshed session only on
success.
| }): Effect.Effect<PollingStatus, InternalErrorResponse> { | ||
| const maxRetries = collector.output.config.pollRetries ?? 60; | ||
| const pollInterval = collector.output.config.pollInterval ?? 2000; | ||
|
|
||
| return validatePollingPrerequisitesµ(store.getState(), challenge).pipe( | ||
| Micro.flatMap(({ interactionId, challengeEndpoint }) => | ||
| Micro.promise(() => | ||
| return Effect.gen(function* () { | ||
| const { interactionId, challengeEndpoint } = yield* validatePollingPrerequisitesµ( | ||
| store.getState(), | ||
| challenge, | ||
| ); | ||
|
|
||
| const doPoll = (): Effect.Effect<PollDispatchResult, never> => | ||
| Effect.promise(() => | ||
| store.dispatch( | ||
| davinciApi.endpoints.poll.initiate({ | ||
| endpoint: challengeEndpoint, | ||
| interactionId, | ||
| }), | ||
| ), | ||
| ), | ||
| ), | ||
| Micro.repeat({ | ||
| while: isChallengeStillPending, | ||
| // `times` tracks repetitions after the initial attempt, so decrement by one | ||
| times: maxRetries - 1, | ||
| schedule: Micro.scheduleSpaced(pollInterval), | ||
| }), | ||
| Micro.map((response) => interpretChallengeResponse(response, log)), | ||
| Micro.flatMap((result) => | ||
| isInternalError(result) ? Micro.fail(result) : Micro.succeed(result), | ||
| ), | ||
| ); | ||
| ); | ||
|
|
||
| let response: PollDispatchResult = yield* doPoll(); | ||
|
|
||
| for (let i = 0; i < maxRetries - 1 && isChallengeStillPending(response); i++) { | ||
| yield* delayMs(pollInterval); | ||
| response = yield* doPoll(); | ||
| } |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the polling configuration contract and its test coverage.
rg -n -C 4 '\bpollRetries\b|\bpollInterval\b' packages e2e tools
rg -n -C 8 'pollStatus|timedOut|isChallengeStillPending|challengePolling' \
--glob '*test.*' packages/davinci-clientRepository: ForgeRock/ping-javascript-sdk
Length of output: 32668
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Effect implementation around pollRetries:"
sed -n '220,330p' packages/davinci-client/src/lib/client.store.effects.ts
echo
echo "All dispatch polling tests:"
rg -n -C 12 'describe|it|pollRetries|timedOut|doPoll|dispatch|initiate' packages/davinci-client/src/lib/client.store.effects.test.ts
echo
echo "Other pollRetries tests mentioning attempted poll counts:"
rg -n -C 8 'pollRetries|attempt|poll.*count|count|timedOut' e2e packages/davinci-client/src --glob '*test.*' \
| sed -n '1,260p'
echo
echo "Programmatic loop count behavior for pending responses:"
python3 - <<'PY'
def loop(maxRetries):
count = 1
i = 0
while i < maxRetries - 1:
count += 1
i += 1
return count
for mr in [-1, 0, 1, 2, 5, 60]:
print(mr, "=>", loop(mr))
PYRepository: ForgeRock/ping-javascript-sdk
Length of output: 35112
Document pollRetries boundary behavior.
The client dispatches once before the retry loop, so pollRetries controls total polling attempts and 0/1 both result in only the initial poll. Add boundary tests for 0, 1, and 2, or rename the config if it should mean retries after the initial attempt.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/davinci-client/src/lib/client.store.effects.ts` around lines 256 -
281, Document that pollRetries represents total polling attempts because doPoll
executes once before the loop, with values 0 and 1 both producing only the
initial poll; add boundary tests covering 0, 1, and 2 using the polling function
and existing test setup. If the intended contract is retries after the initial
attempt instead, rename the configuration and adjust the loop semantics
consistently.
| expect(Exit.isFailure(result)).toBe(true); | ||
| if (!Exit.isFailure(result)) return; | ||
| const errorOpt = Cause.findErrorOption(result.cause); | ||
| if (!Option.isSome(errorOpt)) return; |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n -U --pcre2 \
'const errorOpt = Cause\.findErrorOption\([^;]+;\s*\n\s*if \(!Option\.isSome\(errorOpt\)\) return;' \
packages/oidc-client/src/lib \
-g '*.test.ts'Repository: ForgeRock/ping-javascript-sdk
Length of output: 8531
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Candidate dependency/version files =="
git ls-files | rg '(^|/)(package.json|pnpm-lock.yaml|yarn.lock|package-lock.json)$' || true
echo
echo "== Locate Cause.findErrorOption definitions/usages =="
rg -n "findErrorOption|interface Cause|type Cause|Cause:" packages/oidc-client/src -g '*.ts' | head -200
echo
echo "== Inspect authorize.request.utils.test around listed sites =="
for f in packages/oidc-client/src/lib/authorize.request.utils.test.ts packages/oidc-client/src/lib/logout.request.test.ts packages/oidc-client/src/lib/authorize.request.micros.test.ts; do
echo "--- $f ---"
wc -l "$f"
sed -n '1,320p' "$f"
doneRepository: ForgeRock/ping-javascript-sdk
Length of output: 40129
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== effect dependency version =="
node - <<'JS'
const fs = require('fs');
const pkg = JSON.parse(fs.readFileSync('packages/oidc-client/package.json', 'utf8'));
console.log(pkg.dependencies?.effect ?? pkg.devDependencies?.effect ?? pkg.peerDependencies?.effect ?? 'not found');
JS
echo
echo "== pnpm-lock effect entries =="
rg -n " packages/effect|/effect:" pnpm-lock.yaml | head -100 || true
echo
echo "== Locate Effect error/fail implementations =="
rg -n "function .*error|const .*error|class .*Error|isEffectError|isCause|Cause\\.find|TypedError" node_modules/.pnpm 2>/dev/null | head -200 || trueRepository: ForgeRock/ping-javascript-sdk
Length of output: 294
🌐 Web query:
Effect findErrorOption Cause findErrorOption Effect defect effect 3.x
💡 Result:
In the Effect library, findErrorOption is a function used to extract the first typed error (a "Fail" reason) from a Cause or an Exit [1][2][3][4]. It returns an Option: Option.some(error) if a "Fail" reason exists, and Option.none() if it does not [1][3][4]. Regarding your query about findErrorOption and defects: - When a Cause contains a defect (e.g., created via Cause.die), findErrorOption will return Option.none() [1][3][4]. It is specifically designed to isolate typed errors and ignores other types of failures such as defects or interruptions [2][3][4]. - In Effect 3.x, Cause.failureOption was the equivalent API [5]. This was renamed to findErrorOption in Effect 4.0.0 [2][5][3]. If you need to find defects specifically, you should use findDefect or findDefectOption instead of findErrorOption [2][5][3].
Citations:
- 1: https://github.com/Effect-TS/effect/blob/2e9a34ac/packages/effect/test/Cause.test.ts
- 2: https://github.com/Effect-TS/effect/blob/2e9a34ac/packages/effect/src/Exit.ts
- 3: https://github.com/Effect-TS/effect/blob/main/packages/effect/src/Cause.ts
- 4: https://github.com/Effect-TS/effect-smol/blob/main/packages/effect/src/Cause.ts
- 5: https://github.com/Effect-TS/effect-smol/blob/main/migration/cause.md
Assert errorOpt is Some before reading Effect cause values.
Exit.isFailure also matches defects, but Cause.findErrorOption returns None for defects. The current return skips the expected failure validation and lets the test pass when the cause is a typed die.
Replace each early return with an assertion such as expect(Option.isSome(errorOpt)).toBe(true), then throw or abort the test before reading errorOpt.value.
📍 Affects 3 files
packages/oidc-client/src/lib/authorize.request.utils.test.ts#L140-L143(this comment)packages/oidc-client/src/lib/authorize.request.utils.test.ts#L187-L190packages/oidc-client/src/lib/authorize.request.utils.test.ts#L211-L214packages/oidc-client/src/lib/authorize.request.utils.test.ts#L290-L293packages/oidc-client/src/lib/logout.request.test.ts#L213-L216packages/oidc-client/src/lib/logout.request.test.ts#L251-L254packages/oidc-client/src/lib/logout.request.test.ts#L321-L324packages/oidc-client/src/lib/logout.request.test.ts#L360-L363packages/oidc-client/src/lib/authorize.request.micros.test.ts#L81-L84packages/oidc-client/src/lib/authorize.request.micros.test.ts#L110-L113packages/oidc-client/src/lib/authorize.request.micros.test.ts#L145-L148packages/oidc-client/src/lib/authorize.request.micros.test.ts#L199-L202packages/oidc-client/src/lib/authorize.request.micros.test.ts#L229-L232packages/oidc-client/src/lib/authorize.request.micros.test.ts#L240-L243packages/oidc-client/src/lib/authorize.request.micros.test.ts#L282-L285packages/oidc-client/src/lib/authorize.request.micros.test.ts#L307-L310packages/oidc-client/src/lib/authorize.request.micros.test.ts#L334-L337packages/oidc-client/src/lib/authorize.request.micros.test.ts#L378-L381packages/oidc-client/src/lib/authorize.request.micros.test.ts#L419-L422packages/oidc-client/src/lib/authorize.request.micros.test.ts#L441-L444
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/oidc-client/src/lib/authorize.request.utils.test.ts` around lines
140 - 143, Replace the early returns after Cause.findErrorOption in all listed
sites with assertions that errorOpt is Some, then abort before accessing
errorOpt.value when the assertion fails. Apply this to
authorize.request.utils.test.ts ranges 140-143, 187-190, 211-214, and 290-293;
logout.request.test.ts ranges 213-216, 251-254, 321-324, and 360-363; and
authorize.request.micros.test.ts ranges 81-84, 110-113, 145-148, 199-202,
229-232, 240-243, 282-285, 307-310, 334-337, 378-381, 419-422, and 441-444,
preserving the subsequent typed-error validation.
| expect(Exit.isFailure(exit)).toBe(true); | ||
| if (!Exit.isFailure(exit)) return; | ||
| const errorOpt = Cause.findErrorOption(exit.cause); | ||
| if (!Option.isSome(errorOpt)) return; | ||
| expect(errorOpt.value.error).toBe('no_id_token_hint'); |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Assert that each failed Effect has a typed error.
At Line 207 and the equivalent blocks, the guard returns when Cause.findErrorOption is None. The test then passes if the Effect dies or is interrupted instead of failing with the expected GenericError.
Add an Option.isSome assertion before each guard.
Proposed fix
const errorOpt = Cause.findErrorOption(exit.cause);
+expect(Option.isSome(errorOpt)).toBe(true);
if (!Option.isSome(errorOpt)) return;Also applies to: 247-251, 277-281, 316-320, 339-343, 363-367, 387-391, 441-445, 461-465, 487-491, 521-525, 574-578, 596-600, 652-656, 665-669, 681-685, 698-702, 713-717
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/oidc-client/src/lib/session.micros.test.ts` around lines 204 - 208,
Update each failure assertion block in the session tests, including the blocks
using Cause.findErrorOption, to assert Option.isSome(errorOpt) before the
early-return guard. Keep the existing typed-error value assertions, but ensure a
missing error option fails the test rather than allowing the guard to pass.
| export const UserRuntime = ManagedRuntime.make( | ||
| Layer.provide(Layer.effect(UserService, UserService.make), NodeHttpClient.layerUndici), | ||
| ); |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
ast-grep outline tools/user-scripts/src/lib/user-scripts.ts --items all
fd -t f 'user-scripts.*test.*|user-scripts.*spec.*' tools/user-scripts | while IFS= read -r file; do
echo "=== $file ==="
rg -n -C 4 'UserRuntime|UserService|deleteUser|HttpClientError|DeleteUserError|ManagedRuntime' "$file"
doneRepository: ForgeRock/ping-javascript-sdk
Length of output: 3711
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== user-scripts.ts relevant section ==="
nl -ba tools/user-scripts/src/lib/user-scripts.ts | sed -n '1,160p'
echo "=== tracked test files under tools/user-scripts ==="
git ls-files tools/user-scripts | grep -E '(test|spec|vitest|jest)' || true
echo "=== UserRuntime references ==="
rg -n 'UserRuntime|UserService\.DefaultWithoutDependencies|\.deleteUser\(|HttpClientError|DeleteUserError|getUsers' tools/user-scripts || true
echo "=== package/test config ==="
fd -t f 'package.json|vitest.config.*|jest.config.*|tsconfig.*' tools/user-scripts . | sed -n '1,120p'
for f in $(fd -t f 'package.json|vitest.config.*|jest.config.*|tsconfig.*' tools/user-scripts .); do
echo "--- $f ---"
sed -n '1,220p' "$f"
doneRepository: ForgeRock/ping-javascript-sdk
Length of output: 248
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== user-scripts.ts relevant section ==="
awk '{printf "%4d\t%s\n", NR, $0}' tools/user-scripts/src/lib/user-scripts.ts | sed -n '1,170p'
echo "=== tracked test files under tools/user-scripts ==="
git ls-files tools/user-scripts | grep -E '(test|spec|vitest|jest)' || true
echo "=== UserRuntime references ==="
rg -n 'UserRuntime|UserService\.DefaultWithoutDependencies|\.deleteUser\(|HttpClientError|DeleteUserError|getUsers' tools/user-scripts || true
echo "=== package/test config ==="
find tools/user-scripts . -maxdepth 3 -type f \( -name 'package.json' -o -name 'vitest.config.*' -o -name 'jest.config.*' -o -name 'tsconfig.*' \) -print | sort | while read -r f; do
echo "--- $f ---"
sed -n '1,220p' "$f"
doneRepository: ForgeRock/ping-javascript-sdk
Length of output: 50385
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== git status ==="
git status --short
echo "=== diff for tools/user-scripts ==="
git diff -- tools/user-scripts/src/lib/user-scripts.test.ts tools/user-scripts/src/lib/user-scripts.ts || true
echo "=== user-scripts.test.ts exact relevant block ==="
awk '{printf "%4d\t%s\n", NR, $0}' tools/user-scripts/src/lib/user-scripts.test.ts | sed -n '1,165p'
echo "=== coverage configuration mentions ==="
rg -n 'coverage|user-scripts|tools/user-scripts|tool:.*user-scripts|vitest|enabled' tools/user-scripts/package.json tools/user-scripts/vitest.config.ts package.json nx.json 2>/dev/null || trueRepository: ForgeRock/ping-javascript-sdk
Length of output: 7342
Add uncommented coverage for deleteUser.
tools/user-scripts/src/lib/user-scripts.test.ts still has all tests commented, so no active tests cover config-provided deleteUser success or HttpClientError -> DeleteUserError handling. Enable tests or add new active coverage for these cases.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@tools/user-scripts/src/lib/user-scripts.ts` around lines 96 - 98, Enable or
add active tests in user-scripts.test.ts covering deleteUser with
configuration-provided success behavior and HttpClientError conversion to
DeleteUserError. Keep the tests uncommented and assert both the successful
result and the mapped error outcome.
There was a problem hiding this comment.
Nx Cloud has identified a possible root cause for your failed CI:
We classified this failure as an environment issue rather than a code change. The PAR E2E test successfully reached the external OIDC server (openam-sdks.forgeblocks.com), but the server never redirected back to the expected localhost callback — a behavior controlled entirely by the external service's client registration, not by our Effect v3 → v4 migration. No changes in this PR affect PAR redirect URIs or the oidc-suites test infrastructure.
No code changes were suggested for this issue.
Trigger a rerun:
🎓 Learn more about Self-Healing CI on nx.dev
1 participant
Summary
Migrates the entire SDK from
effect@^3.20(v3) toeffect@4.0.0-beta.103(v4 beta).Changes by package
pnpm-workspace.yaml(catalog)effect: '4.0.0-beta.103'@effect/vitest: '4.0.0-beta.103'@effect/platform-node: '4.0.0-beta.103'@effect/platformand@effect/cli(consolidated intoeffectcore)vitestcatalog to^4.1.0packages/sdk-utilitiesmicro.utils.ts:MicroExit/exitIsFail/exitIsSuccess/causeIsDie→Exit/Cause; renamedhandleMicroExit→handleExitconfig.types/utils/effects/test:Either→Result(succeed/fail/isSuccess/isFailure)packages/journey-clientjourney.utils.ts:Either.right/left→Result.succeed/failclient.store.ts:Either.match→Result.match(onFailure/onSuccess)_tag: 'Right'/'Left'→'Success'/'Failure';.right/.left→.success/.failurepackages/oidc-client(12 files)Micro.*→Effect.*Cause.failureOption→Cause.findErrorOption(returnsOption<E>)exitIsFail(exit)→Cause.findErrorOption(exit.cause)+Option.isSomevi.clearAllMocks()inafterEachto fix accumulated mock call countspackages/davinci-client(5 files)Micro.*→Effect.*Effect.repeat({while})→Effect.gen+ manual loop (v4whilereceives schedule output type, not effect output)password-policy.rules.ts:Array.filterMapnow expectsResultcallbacks;Option.some/none()→Result.succeed/failVoidContext.Tag→Context.Servicee2e/mock-api-v2(full migration)from '@effect/platform'→from 'effect/unstable/httpapi'Context.Tag→Context.ServiceEffect.if→Effect.suspend(() => bool ? ... : ...)Option.fromNullable→Option.fromNullishOrSchema.Union(a, b)→Schema.Union([a, b])Schema.Record({key, value})→Schema.Record(key, value)Schema.Schema<T, T>→Schema.Schema<T>HttpApiMiddleware.Tag→HttpApiMiddleware.Service<Self, {provides: T}>()nxBuild→buildVerification
Summary by CodeRabbit
Bug Fixes
Improvements
Tests