Skip to content

OPT: Add checks if user already submitted links - #37

Merged
PBXg33k merged 5 commits into
developfrom
feature/duplicate-downloads
Aug 22, 2026
Merged

OPT: Add checks if user already submitted links#37
PBXg33k merged 5 commits into
developfrom
feature/duplicate-downloads

Conversation

@PBXg33k

@PBXg33k PBXg33k commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@github-actions

Copy link
Copy Markdown

badge

Code Coverage Summary

Filename                                                         Stmts    Miss  Cover    Missing
-------------------------------------------------------------  -------  ------  -------  -----------------------------------------
Command/CoreDownloadersUpdateCommand.php                            19      19  0.00%    22-57
Command/DownloadRouterMigrationSetDownloadjobOwnerCommand.php       33      33  0.00%    32-93
Command/ScanDownloadedFilesCommand.php                              38      38  0.00%    30-98
Command/UrlDownloadCommand.php                                      40       6  85.00%   45-50, 100-102
Controller/AuthController.php                                      238      12  94.96%   297-302, 356, 368-372
Controller/DownloadController.php                                   31      31  0.00%    20-84
Controller/WellKnownController.php                                  51       0  100.00%
DataFixtures/TestUserFixtures.php                                    4       0  100.00%
Doctrine/CurrentUserExtension.php                                    9       0  100.00%
Dto/CookieDTO.php                                                   36       5  86.11%   27, 32-37, 42
Dto/DownloadJobDTO.php                                               0       0  0.00%
Dto/JobAcceptedDTO.php                                              15       0  100.00%
Entity/AbstractSiteSetting.php                                      16       3  81.25%   37-44
Entity/DownloadJob.php                                              67       5  92.54%   156, 186, 304-306
Entity/DownloadJobEvent.php                                         33      19  42.42%   67-75, 92-99, 116, 128, 140, 152, 164-179
Entity/DownloadedFile.php                                           24      18  25.00%   67-71, 92-149
Entity/OidcSubjectIdentifier.php                                    28      13  53.57%   106-145
Entity/SiteSetting.php                                               6       0  100.00%
Entity/SupportedSite.php                                            33       0  100.00%
Entity/UserSetting.php                                               3       0  100.00%
Entity/UserSiteSetting.php                                          14       4  71.43%   68-71
Enum/DownloadStateEnum.php                                           7       7  0.00%    16-22
Enum/DownloaderTypeEnum.php                                          3       0  100.00%
Enum/JobTypeEnum.php                                                 2       0  100.00%
Event/CliProcessErrOutputEvent.php                                   1       0  100.00%
Event/CliProcessOutputEvent.php                                      2       1  50.00%   21
Event/CliProcessStartEvent.php                                       1       0  100.00%
Event/CliProcessStdOutputEvent.php                                   1       0  100.00%
Event/CliProcessStopEvent.php                                        1       0  100.00%
Event/JobCompletedEvent.php                                          4       0  100.00%
Event/JobFailedEvent.php                                             5       0  100.00%
Event/JobPickedUpEvent.php                                           4       0  100.00%
Event/JobUpdateEvent.php                                             5       0  100.00%
Event/ProcessStartEvent.php                                          1       0  100.00%
Event/ProcessStopEvent.php                                           1       0  100.00%
EventListener/CleanupListener.php                                    9       0  100.00%
EventListener/CliProcessListener.php                                30       1  96.67%   76
EventListener/JobEventLogger.php                                    59       0  100.00%
EventListener/ProcessStoppedListener.php                            44       2  95.45%   79, 85
Factory/DownloaderFactory.php                                       18       0  100.00%
Handler/DownloadJobDTOHandler.php                                    1       1  0.00%    14
Handler/DownloadJobHandler.php                                      51       0  100.00%
Message/UpdateDownloadersMessage.php                                 0       0  0.00%
MessageHandler/UpdateDownloadersMessageHandler.php                  10       0  100.00%
Repository/DownloadJobEventRepository.php                            1       0  100.00%
Repository/DownloadJobRepository.php                                24      16  33.33%   22-36, 52-56
Repository/DownloadedFileRepository.php                              1       0  100.00%
Repository/OidcSubjectIdentifierRepository.php                       1       0  100.00%
Repository/SiteSettingRepository.php                                 1       0  100.00%
Repository/SupportedSiteRepository.php                               1       0  100.00%
Repository/UserDownloadStatsRepository.php                           1       0  100.00%
Repository/UserSettingRepository.php                                 1       0  100.00%
Resource/Downloader.php                                              0       0  0.00%
Resource/Stats/UserDownloadStats.php                                 5       5  0.00%    34-39
Resource/UserStats.php                                               3       0  100.00%
Resource/Version.php                                                 1       0  100.00%
Response/ErrorResponse.php                                           5       0  100.00%
Security/Core/User/OidcUser.php                                      6       1  83.33%   32
Security/Core/User/OidcUserProvider.php                             38       0  100.00%
Service/Downloader/AbstractCliDownloader.php                       105      65  38.10%   37-102, 111, 131, 143-149, 185, 191, 200
Service/Downloader/GalleryDlCliDownloader.php                      106      97  8.49%    45-195, 202, 212, 225-228
Service/Downloader/MockDownloader.php                                8       0  100.00%
Service/Downloader/YoutubeDlCliDownloader.php                      134     124  7.46%    54-189, 196, 206, 214-284, 294-297
State/DownloadJobQueuedProcessor.php                                68       1  98.53%   65
State/DownloaderProvider.php                                        24       0  100.00%
State/UserStatsProvider.php                                          7       0  100.00%
State/VersionProvider.php                                           34       0  100.00%
Validator/SelectDownloader.php                                       1       0  100.00%
Validator/SelectDownloaderValidator.php                              8       0  100.00%
TOTAL                                                             1582     527  66.69%

Diff against develop

Filename                                Stmts    Miss  Cover
------------------------------------  -------  ------  -------
Repository/DownloadJobRepository.php      +12      +5  +25.00%
State/DownloadJobQueuedProcessor.php      +14       0  +0.38%
TOTAL                                     +26      +5  +0.24%

Results for commit: f00f3c0

Minimum allowed coverage is 35%

♻️ This comment has been updated with latest results

@PBXg33k
PBXg33k merged commit c1e0d96 into develop Aug 22, 2026
4 checks passed
@PBXg33k
PBXg33k deleted the feature/duplicate-downloads branch August 22, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant