Rework marking interface to use Vectors - #4476
Open
schnellerhase wants to merge 3 commits into
Open
Conversation
schnellerhase
changed the title
schnellerhase
force-pushed
the
schnellerhase/fix-marking
branch
from
September 5, 2026 13:02
7374302 to
494fe36
Compare
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| import pytest | ||
|
|
||
| from dolfinx import mesh | ||
| import dolfinx |
schnellerhase
force-pushed
the
schnellerhase/fix-marking
branch
from
September 5, 2026 14:42
cbc220c to
46092bc
Compare
schnellerhase
marked this pull request as ready for review
September 5, 2026 14:58
Member
|
Looks good. I have a few small suggestions to make, but away from PC until Wednesday. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4156 missed the handling of ghost entries; caught by @jhale in extending upon PR #4187.
The underlying issue is that marker computation needs to happen on locally owned entities; while the marked entities (output) need to include ghost members. The dolfinx native way to achieve this is to just rely on a vector which carries exactly the infrastructure to differentiate between ghosted and non-ghosted contributions. Also this makes the caller interface simpler; as usually markers are$\mathcal{DG}_0$ functions anyhow.
mark_maximumnow computes the max over the locally owned entries (no change here, max. is insensitive to duplicates - but delicate for other markers)