Skip to content

fix: shorten localized labels - #567

Open
lowrt wants to merge 2 commits into
mainfrom
ci
Open

fix: shorten localized labels#567
lowrt wants to merge 2 commits into
mainfrom
ci

Conversation

@lowrt

@lowrt lowrt commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

這個 PR 做了什麼

相關 issue

  • closes #

怎麼驗

檢查清單

  • tool/check/commits.sh origin/main..HEAD 通過
    —— commit 訊息就是更新日誌,格式見 commit.md
  • 一個 commit 一件事(這條 gate 驗不了,靠自己和 review)
  • mise exec -- flutter analyzemise exec -- flutter test 通過
  • 新的使用者可見字串都走 AppLocalizations,沒有寫死
  • 有 UI 變更的話:用的是 AppSpacing / AppRadius / AppMotion
    深色模式看過,文字對比度可接受

- Upgrade checkout and cache actions to current versions
- Remove redundant Gradle cache from Android CI
- Keep release workflow cache cleanup for a separate change
@lowrt
lowrt requested a review from a team as a code owner September 6, 2026 14:23
@lowrt
lowrt enabled auto-merge (rebase) September 6, 2026 14:23
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown

🔍 OpenCodeReview found 6 issue(s) in this PR.

  • ✅ Successfully posted inline: 6 comment(s)

Comment thread .github/workflows/android.yml
@pull-request-size pull-request-size Bot added size/M and removed size/S labels Sep 7, 2026
@lowrt lowrt changed the title ci: update Android and iOS actions fix: shorten localized labels Sep 7, 2026
@lowrt
lowrt disabled auto-merge September 7, 2026 06:19
Comment thread lib/l10n/gen/app_localizations_en.dart
Comment thread lib/l10n/gen/app_localizations_en.dart
Comment on lines 15 to 16
outputs:
android: ${{ steps.filter.outputs.android }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other · low
建議為 Job 設定 timeout-minutes。這可以防止因某些步驟卡住而導致 GitHub Actions Runner 被無限期佔用,從而節省資源並避免建置流程掛起。

Comment thread .github/workflows/android.yml
Comment thread .github/workflows/ios.yml
Comment on lines 15 to 16
outputs:
ios: ${{ steps.filter.outputs.ios }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other · low
建議為 Job 設定 timeout-minutes。這可以防止因某些步驟卡住而導致 GitHub Actions Runner 被無限期佔用,從而節省資源並避免建置流程掛起。

Comment thread lib/l10n/gen/app_localizations_fil.dart Outdated
Comment thread lib/l10n/gen/app_localizations_fil.dart Outdated
Comment thread lib/l10n/gen/app_localizations_fil.dart Outdated
Fix(zh-Hant): 縮短多語系名稱以避免文字超出容器
Fix(en-US): shorten localized labels to prevent text overflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant