Skip to content

Fix cargo lock updater workflow - take 2#1423

Merged
tsmbland merged 5 commits into
mainfrom
fix-cargo-lock-updater-workflow
Jul 16, 2026
Merged

Fix cargo lock updater workflow - take 2#1423
tsmbland merged 5 commits into
mainfrom
fix-cargo-lock-updater-workflow

Conversation

@dc2917

@dc2917 dc2917 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

It appears I was making things unnecessarily complicated for myself before, manually creating a git user and making the commit, when I could have just got the peter-evans/create-pull-request action to do that.

I ran the action from this branch (see run here) which successfully created the pull request (#1422) which auto-merged, so this does indeed appear to be working now.

Fixes #1380

@dc2917
dc2917 requested a review from tsmbland July 16, 2026 14:27

@tsmbland tsmbland left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Can you revert #1422 so we can get the fix without updating Cargo.lock?

The regression tests are all failing, I think because the updated highs is probably changing results. Something we'll have to look into separately. I imagine this could happen quite often...

Failing tests should prevent auto-merge, although I guess PRs into non-main branches don't have this restriction which is why it worked into this branch

@dc2917

dc2917 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

The regression tests are all failing, I think because the updated highs is probably changing results. Something we'll have to look into separately. I imagine this could happen quite often...

Yeah, I did wonder if that was the cause. Definitely annoying, but yeah, as long as this doesn't auto-merge because main is the base branch, we can act accordingly.

Great! Can you revert #1422 so we can get the fix without updating Cargo.lock?

Done

@dc2917
dc2917 requested a review from tsmbland July 16, 2026 15:02
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.80%. Comparing base (93a8e31) to head (61267fe).
⚠️ Report is 47 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1423      +/-   ##
==========================================
- Coverage   89.42%   86.80%   -2.62%     
==========================================
  Files          59       59              
  Lines        8367     8384      +17     
  Branches     8367     8384      +17     
==========================================
- Hits         7482     7278     -204     
- Misses        564      790     +226     
+ Partials      321      316       -5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsmbland
tsmbland merged commit 252421b into main Jul 16, 2026
7 of 8 checks passed
@tsmbland
tsmbland deleted the fix-cargo-lock-updater-workflow branch July 16, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cargo.lock update workflow creates branch but not PR

2 participants