Fix cargo lock updater workflow - take 2#1423
Conversation
tsmbland
left a comment
There was a problem hiding this comment.
Great! Can you revert #1422 so we can get the fix without updating Cargo.lock?
The regression tests are all failing, I think because the updated highs is probably changing results. Something we'll have to look into separately. I imagine this could happen quite often...
Failing tests should prevent auto-merge, although I guess PRs into non-main branches don't have this restriction which is why it worked into this branch
This reverts commit 463373d.
Yeah, I did wonder if that was the cause. Definitely annoying, but yeah, as long as this doesn't auto-merge because
Done |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1423 +/- ##
==========================================
- Coverage 89.42% 86.80% -2.62%
==========================================
Files 59 59
Lines 8367 8384 +17
Branches 8367 8384 +17
==========================================
- Hits 7482 7278 -204
- Misses 564 790 +226
+ Partials 321 316 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
It appears I was making things unnecessarily complicated for myself before, manually creating a git user and making the commit, when I could have just got the
peter-evans/create-pull-requestaction to do that.I ran the action from this branch (see run here) which successfully created the pull request (#1422) which auto-merged, so this does indeed appear to be working now.
Fixes #1380