Restore Banxa and Paybis sell after provider payment-method code changes#6106
Open
j0ntz wants to merge 2 commits into
Open
Restore Banxa and Paybis sell after provider payment-method code changes#6106j0ntz wants to merge 2 commits into
j0ntz wants to merge 2 commits into
Conversation
Paybis renamed its US off-ramp payout method to method-id-mass-pay-credit-card-out. The plugin only knew the retired method-id-credit-card-out / method-id-mass-pay-out slugs, both of which the quote API now rejects with 422, so US Paybis sell returned no quote. Add the current slug to the payment-method allowlist and map it to the credit payment type so initializeSellPairs picks up the API-returned id.
Banxa's off-ramp payment-method codes for card, PIX and AU bank transfer (CHECKOUTPO, DLOCALPIXPO, BCCONNECTSELL) were absent from the strict paymentType allowlist, so asMaybe dropped them and those sell methods never surfaced. Add the three codes to the allowlist and typeMap (CHECKOUTPO -> credit, DLOCALPIXPO -> pix, BCCONNECTSELL -> directtobank) and enable credit for sell so the Banxa EUR card payout is offered.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Author
📸 Test evidence (sell quotes restored)paybis us sell quote
banxa eur card sell quote
Captured by the agent's in-app test run (build-and-test). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Dependencies
none
Requirements
Description
Banxa and Paybis off-ramp (sell) were broken or degraded in the live ramp flow because both providers changed their payment-method codes and the ramp plugins no longer recognized them. Confirmed against each provider's live API and reproduced in-app on the iOS sim. Scope is the new ramp plugin architecture (the live sell path); the legacy
providers/*plugins are reachable only via DevTestScene.Paybis (US card payout)
Paybis migrated its US off-ramp payout method to the slug
method-id-mass-pay-credit-card-out. The plugin only knewmethod-id-credit-card-outandmethod-id-mass-pay-out, both of which the quote API now rejects with HTTP 422. SincerampConstraintsallows Paybis sell only for US + card, every Paybis sell returned zero quotes. Fix: add the current slug to the payment-method allowlist andPAYMENT_METHOD_MAP(mapped tocredit); the plugin already prefers the API-returned payout id viasellPayoutMethodIds.Banxa (renamed sell payout codes)
Banxa's off-ramp codes
CHECKOUTPO(EUR card payout),DLOCALPIXPO(BRL PIX) andBCCONNECTSELL(AUD bank transfer) were missing from the strictasBanxaPaymentTypeallowlist, soasMaybedropped them and those sell methods never surfaced. Fix: add the three codes to the allowlist andtypeMap(CHECKOUTPOtocredit,DLOCALPIXPOtopix,BCCONNECTSELLtodirecttobank) and enablecreditfor Banxa sell so the EUR card payout is offered.Documented blockers / gaps (intentionally not changed)
BRDGACHSELL): blocked inrampConstraints"pending bank registration issue resolution" (unresolved in #banxa-dev since Oct 2025). Left blocked.CLEARJCNSELLSEPA): disabled viasepa: false("leave this to Bity"). Left disabled.rampConstraints(US + card only). Left as-is.Testing (iOS sim, edge-funds)
CHECKOUTPO/DLOCALPIXPO/BCCONNECTSELLare ACTIVE sell methods.verify-repo.shgreen (tsc, eslint, jest).Asana: Ramps - Fix banxa+paybis sell
Note
Low Risk
Narrow allowlist and mapping updates in ramp plugins only; no auth, custody, or payment execution logic changes.
Overview
Restores off-ramp (sell) quotes for Banxa and Paybis after both providers renamed or retired payment-method identifiers that the ramp plugins no longer recognized.
For Paybis US card payout, the quote API now uses
method-id-mass-pay-credit-card-outinstead of retired slugs that returned HTTP 422, which had left Paybis sell with zero quotes where only US + card is allowed.For Banxa sell, three provider codes are added to the strict
asBanxaPaymentTypeallowlist andtypeMap(CHECKOUTPO→ EUR card,DLOCALPIXPO→ PIX,BCCONNECTSELL→ AUD bank), and sellrampConstraintsenablecreditso EUR card payout can surface.CHANGELOG records the user-facing fix.
Reviewed by Cursor Bugbot for commit a592c79. Bugbot is set up for automated code reviews on this repo. Configure here.