Migrate raw keys and master private key warnings to UI4 card - #6095
Closed
j0ntz wants to merge 2 commits into
Closed
Migrate raw keys and master private key warnings to UI4 card#6095j0ntz wants to merge 2 commits into
j0ntz wants to merge 2 commits into
Conversation
Add explicit return types, type catch callback as unknown, and replace the styled() wrapper with a plain View + StyleSheet component.
The Reveal Raw Keys and Reveal Master Private Key password screens shared TextInputModal's legacy bordered Alert component for their warning text. Swap it for the UI4 AlertCardUi4 (gradient card + icon), matching the Export Logs modal's warning card and edge-login-ui-rn's own already-UI4'd TextInputModal.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Author
📸 Test evidencemaster private key warning
raw keys warning
Captured by the agent's in-app test run (build-and-test). |
6 tasks
Contributor
Author
|
Superseded by #6105, which consolidates this and 11 other small GUI task branches into one PR/branch per the umbrella task's instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Description
The Reveal Raw Keys and Reveal Master Private Key password confirmation
screens still used the legacy bordered
Alertcomponent for their warningtext, while the Export Logs modal (the UI4 reference) uses the solid
gradient
AlertCardUi4card. This PR swapsTextInputModal's warningrender (shared by both screens) from
AlerttoAlertCardUi4, matchingthe Export Logs style and
edge-login-ui-rn's own copy ofTextInputModal,which had already made this same change.
Verified live on the iOS sim: Wallet List menu -> Master Private Key and
Get Raw Keys both now show the gradient warning card instead of the old
outlined box (screenshots attached below).
Asana task
Note
Low Risk
Presentation-only change in a shared modal; no auth, key derivation, or password-check logic is modified.
Overview
Password confirmation modals for Reveal Raw Keys and Reveal Master Private Key now show warnings with the UI4
AlertCardUi4gradient card instead of the legacy borderedAlert, aligned with Export Logs andedge-login-ui-rn.TextInputModalmapswarningMessagetoAlertCardUi4(type="warning", localized title,bodyprop) and drops the oldstyledlayout in favor ofStyleSheetfor the multiline inner container. Snapshots and ESLint coverage for the modal are updated accordingly; CHANGELOG notes the user-visible change.Reviewed by Cursor Bugbot for commit f40e807. Bugbot is set up for automated code reviews on this repo. Configure here.