Skip to content

Wrap fiat value in parens on Stake amount tile#6093

Closed
j0ntz wants to merge 2 commits into
developfrom
jon/stake-fiat-value-brackets
Closed

Wrap fiat value in parens on Stake amount tile#6093
j0ntz wants to merge 2 commits into
developfrom
jon/stake-fiat-value-brackets

Conversation

@j0ntz

@j0ntz j0ntz commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Description

Asana task

The Stake/Unstake/Claim amount row (EditableAmountTile) rendered the fiat
value raw, right after the crypto amount, with no surrounding brackets.
Its compressed render branch and the sibling CryptoFiatAmountTile
(used on the Earn overview list) already wrap fiat text in parens; the
default (non-compressed) branch was the one instance still missing it.
Wrapped it to match.

The exact "staked / earned / unstaked" overview rows from the original
repro (CryptoFiatAmountTile on the Earn overview scene) were already
fixed on develop by an unrelated refactor (bbd3259a6, 2025-10-17,
predates this branch) — no change needed there.

Asana: https://app.asana.com/1/9976422036640/project/1201386023359434/task/1210364105386494

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Low Risk
Display-only formatting on a shared tile component; no payment, staking, or rate logic changes.

Overview
Stake/Unstake/Claim amount rows use EditableAmountTile. The default layout showed the fiat equivalent next to the crypto amount without parentheses, while the compressed branch and CryptoFiatAmountTile already used (fiat).

The default branch now renders fiat as (${fiatAmountSyntax}), aligned with those patterns. Fiat text is only built when fiatAmount !== '' (instead of a truthy check). The component is typed as React.FC. CHANGELOG and Send scene snapshots are updated.

Reviewed by Cursor Bugbot for commit bf88456. Bugbot is set up for automated code reviews on this repo. Configure here.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@j0ntz

j0ntz commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

📸 Test evidence

unstake fiat brackets

unstake fiat brackets

Captured by the agent's in-app test run (build-and-test).

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 020cf18. Configure here.

Comment thread src/components/tiles/EditableAmountTile.tsx Outdated
j0ntz added 2 commits July 23, 2026 19:48
The non-compressed EditableAmountTile render branch showed the fiat
amount raw right after the crypto amount with no brackets, unlike its
compressed branch and CryptoFiatAmountTile which already wrap fiat text
in parens.
@j0ntz
j0ntz force-pushed the jon/stake-fiat-value-brackets branch from 020cf18 to bf88456 Compare July 24, 2026 02:51
@j0ntz

j0ntz commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #6105, which consolidates this and 11 other small GUI task branches into one PR/branch per the umbrella task's instructions.

@j0ntz j0ntz closed this Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant