Wrap fiat value in parens on Stake amount tile#6093
Closed
j0ntz wants to merge 2 commits into
Closed
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Author
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 020cf18. Configure here.
The non-compressed EditableAmountTile render branch showed the fiat amount raw right after the crypto amount with no brackets, unlike its compressed branch and CryptoFiatAmountTile which already wrap fiat text in parens.
j0ntz
force-pushed
the
jon/stake-fiat-value-brackets
branch
from
July 24, 2026 02:51
020cf18 to
bf88456
Compare
6 tasks
Contributor
Author
|
Superseded by #6105, which consolidates this and 11 other small GUI task branches into one PR/branch per the umbrella task's instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Asana task
The Stake/Unstake/Claim amount row (
EditableAmountTile) rendered the fiatvalue raw, right after the crypto amount, with no surrounding brackets.
Its
compressedrender branch and the siblingCryptoFiatAmountTile(used on the Earn overview list) already wrap fiat text in parens; the
default (non-compressed) branch was the one instance still missing it.
Wrapped it to match.
The exact "staked / earned / unstaked" overview rows from the original
repro (
CryptoFiatAmountTileon the Earn overview scene) were alreadyfixed on
developby an unrelated refactor (bbd3259a6, 2025-10-17,predates this branch) — no change needed there.
Asana: https://app.asana.com/1/9976422036640/project/1201386023359434/task/1210364105386494
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Low Risk
Display-only formatting on a shared tile component; no payment, staking, or rate logic changes.
Overview
Stake/Unstake/Claim amount rows use
EditableAmountTile. The default layout showed the fiat equivalent next to the crypto amount without parentheses, while the compressed branch andCryptoFiatAmountTilealready used(fiat).The default branch now renders fiat as
(${fiatAmountSyntax}), aligned with those patterns. Fiat text is only built whenfiatAmount !== ''(instead of a truthy check). The component is typed asReact.FC. CHANGELOG and Send scene snapshots are updated.Reviewed by Cursor Bugbot for commit bf88456. Bugbot is set up for automated code reviews on this repo. Configure here.