Skip to content

Update custom icon font with new designs#6092

Closed
j0ntz wants to merge 1 commit into
developfrom
jon/custom-icon-updates
Closed

Update custom icon font with new designs#6092
j0ntz wants to merge 1 commit into
developfrom
jon/custom-icon-updates

Conversation

@j0ntz

@j0ntz j0ntz commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Description

Regenerates the fontello custom icon font from the designer SVGs attached to
the Asana task, which asked
for the app's custom icons to be brought in line with the updated design ("we just need
to fix the inconsistencies we have").

Five existing glyphs are replaced in place, keeping their name and codepoint so every
call site picks up the new artwork with no code change:

Glyph Where it renders
buy Buy bottom tab
sell Sell bottom tab
sort Assets wallet-list header sort button
control-panel-scan-qr Side menu, Scan QR
control-panel-fio-names Side menu, FIO Names

The sixth SVG is a chart icon, which the font did not have. It lands as a new chart
glyph and replaces the FontAwesome chart-line on the side menu's Markets row: that
solid glyph was the odd one out in an otherwise all-outline menu, which is the kind of
inconsistency this task is about.

The font is rebuilt through the fontello session API rather than by hand. Posting the
checked-in config.json back to it reproduces the committed custom.ttf byte for byte
apart from the head timestamps, table checksum and version string, so the only outline
changes in this diff are the six intended glyphs. android/app/src/main/assets/fonts/custom.ttf
is the only font file: ios/edge.xcodeproj/project.pbxproj references that same path,
so iOS and Android share it.

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Driven on the iOS 18.6 simulator: the Assets scene (Buy / Sell tabs and the wallet-list
sort button) and the side menu (FIO Names, Scan QR, Markets). Screenshots below.


Note

Low Risk
Visual-only icon font and one side-menu icon source change; no business logic, auth, or data handling.

Overview
Refreshes the Fontello custom icon font so several in-app glyphs match the updated outline design while keeping the same names and codepoints (buy, sell, sort, control-panel-scan-qr, control-panel-fio-names), so existing iconName usages pick up new artwork without call-site changes.

Adds a new chart glyph and updates SideMenu so the Markets drawer row uses iconName: 'chart' instead of FontAwesome chart-line, aligning that row with the rest of the outline side menu icons.

CHANGELOG.md documents the icon refresh.

Reviewed by Cursor Bugbot for commit 41cba60. Bugbot is set up for automated code reviews on this repo. Configure here.

Regenerated the fontello 'custom' font from the designer SVGs attached to
the task. The buy, sell, sort and control-panel-scan-qr glyphs are replaced
with the updated artwork, and two new glyphs (list, chart) are added.

The font is rebuilt through the fontello session API, which reproduces the
existing custom.ttf byte for byte from the checked-in config, so the only
outline changes are the six intended glyphs.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@j0ntz

j0ntz commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

📸 Test evidence

assets tabbar and sort

assets tabbar and sort

side menu fio names scan qr markets

side menu fio names scan qr markets

Captured by the agent's in-app test run (build-and-test).

@j0ntz

j0ntz commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #6105, which consolidates this and 11 other small GUI task branches into one PR/branch per the umbrella task's instructions.

@j0ntz j0ntz closed this Jul 24, 2026
@j0ntz
j0ntz deleted the jon/custom-icon-updates branch July 24, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant