Update custom icon font with new designs#6092
Closed
j0ntz wants to merge 1 commit into
Closed
Conversation
Regenerated the fontello 'custom' font from the designer SVGs attached to the task. The buy, sell, sort and control-panel-scan-qr glyphs are replaced with the updated artwork, and two new glyphs (list, chart) are added. The font is rebuilt through the fontello session API, which reproduces the existing custom.ttf byte for byte from the checked-in config, so the only outline changes are the six intended glyphs.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Author
6 tasks
Contributor
Author
|
Superseded by #6105, which consolidates this and 11 other small GUI task branches into one PR/branch per the umbrella task's instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Regenerates the fontello
customicon font from the designer SVGs attached tothe Asana task, which asked
for the app's custom icons to be brought in line with the updated design ("we just need
to fix the inconsistencies we have").
Five existing glyphs are replaced in place, keeping their name and codepoint so every
call site picks up the new artwork with no code change:
buysellsortcontrol-panel-scan-qrcontrol-panel-fio-namesThe sixth SVG is a chart icon, which the font did not have. It lands as a new
chartglyph and replaces the FontAwesome
chart-lineon the side menu's Markets row: thatsolid glyph was the odd one out in an otherwise all-outline menu, which is the kind of
inconsistency this task is about.
The font is rebuilt through the fontello session API rather than by hand. Posting the
checked-in
config.jsonback to it reproduces the committedcustom.ttfbyte for byteapart from the
headtimestamps, table checksum and version string, so the only outlinechanges in this diff are the six intended glyphs.
android/app/src/main/assets/fonts/custom.ttfis the only font file:
ios/edge.xcodeproj/project.pbxprojreferences that same path,so iOS and Android share it.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Driven on the iOS 18.6 simulator: the Assets scene (Buy / Sell tabs and the wallet-list
sort button) and the side menu (FIO Names, Scan QR, Markets). Screenshots below.
Note
Low Risk
Visual-only icon font and one side-menu icon source change; no business logic, auth, or data handling.
Overview
Refreshes the Fontello custom icon font so several in-app glyphs match the updated outline design while keeping the same names and codepoints (
buy,sell,sort,control-panel-scan-qr,control-panel-fio-names), so existingiconNameusages pick up new artwork without call-site changes.Adds a new
chartglyph and updatesSideMenuso the Markets drawer row usesiconName: 'chart'instead of FontAwesomechart-line, aligning that row with the rest of the outline side menu icons.CHANGELOG.mddocuments the icon refresh.Reviewed by Cursor Bugbot for commit 41cba60. Bugbot is set up for automated code reviews on this repo. Configure here.