Sort Privacy Settings asset list alphabetically#6090
Closed
j0ntz wants to merge 1 commit into
Closed
Conversation
The Nym Mix Net Assets list order followed plugin registration order, which differs between iOS and Android, producing inconsistent and non-alphabetical ordering on both platforms.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Author
📸 Test evidenceprivacy settings sorted
Captured by the agent's in-app test run (build-and-test). |
6 tasks
Contributor
Author
|
Superseded by #6105, which consolidates this and 11 other small GUI task branches into one PR/branch per the umbrella task's instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Asana task
The Nym Mixnet asset list on the Privacy Settings scene was ordered by plugin registration order instead of alphabetically, so the list rendered in different, inconsistent orders on iOS vs Android (QA repro: iOS started with Monero, Android started with Abstract with Monero at the bottom).
Fix:
PrivacySettingsScene.tsx'ssupportedPluginIdsmemo now sorts the filtered plugin list bycurrencyInfo.displayName(the label actually rendered in each row) vialocaleCompare, so the list is alphabetical and platform-independent.Privacy Settings - List Sorting Order
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Tested on the iOS simulator only (screenshot attached below), confirming the asset list now renders alphabetically (Abstract, Amoy Testnet, Arbitrum One, Avalanche, Axelar, Base, BNB Smart Chain, BOB, ...). The sort is platform-agnostic (plain array sort on shared data), so it applies identically on Android; not separately verified on an Android device.
Note
Low Risk
Display-order only in Privacy Settings; no changes to toggles, persistence, or network privacy behavior.
Overview
Privacy Settings now lists Nym Mixnet-capable assets in alphabetical order by
displayName, instead of whatever ordercurrencyConfigkeys happen to use (which differed on iOS vs Android).The
supportedPluginIdsmemo inPrivacySettingsScenestill filters plugins with private-networking defaults; it now sorts that list withlocaleCompareon the same label each row shows. CHANGELOG updated under Unreleased.Reviewed by Cursor Bugbot for commit 69eff62. Bugbot is set up for automated code reviews on this repo. Configure here.