Skip to content

Style entire signin line as tertiary link on getting-started scene#6089

Closed
j0ntz wants to merge 1 commit into
developfrom
jon/usps-signin-line-color
Closed

Style entire signin line as tertiary link on getting-started scene#6089
j0ntz wants to merge 1 commit into
developfrom
jon/usps-signin-line-color

Conversation

@j0ntz

@j0ntz j0ntz commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Description

Asana task

Style the entire "Already have an account? Sign in" line on the getting-started USP carousel as the tertiary link color (theme.iconTappable), not just the "Sign in" word. The line was already a single tap target (EdgeTouchableOpacity wraps both spans); only the color changes.

USPs - Signin UI clarification

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Low Risk
Cosmetic color change on the getting-started screen only; no navigation, auth, or data handling changes.

Overview
On the getting-started USP carousel, the entire “Already have an account? Sign in” row now uses the tertiary link color (theme.iconTappable), not only the “Sign in” span.

tertiaryText in GettingStartedScene is updated from theme.textInputTextColorDisabled to match tappableText. Tap behavior is unchanged—the row was already one EdgeTouchableOpacity target.

Reviewed by Cursor Bugbot for commit 6280f0b. Bugbot is set up for automated code reviews on this repo. Configure here.

Previously only "Sign in" was colored as a tappable link; "Already
have an account?" was dimmed even though the whole line is already
one tap target.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@j0ntz

j0ntz commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

📸🩹 Test evidence

🩹 Some screenshots below are HACK-FORCED. The marked frames show a state forced by a temporary uncommitted local edit (the natural trigger could not be reproduced on the sim). The hack is not in this PR's diff; the pixels prove the rendering, not the trigger.

🩹 HACK-FORCED: signin line green

🩹 HACK-FORCED: signin line green

🩹 HACK-FORCED: tap navigates signin

🩹 HACK-FORCED: tap navigates signin

Captured by the agent's in-app test run (build-and-test).

@j0ntz

j0ntz commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #6105, which consolidates this and 11 other small GUI task branches into one PR/branch per the umbrella task's instructions.

@j0ntz j0ntz closed this Jul 24, 2026
@j0ntz
j0ntz deleted the jon/usps-signin-line-color branch July 24, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant