Style entire signin line as tertiary link on getting-started scene#6089
Closed
j0ntz wants to merge 1 commit into
Closed
Style entire signin line as tertiary link on getting-started scene#6089j0ntz wants to merge 1 commit into
j0ntz wants to merge 1 commit into
Conversation
Previously only "Sign in" was colored as a tappable link; "Already have an account?" was dimmed even though the whole line is already one tap target.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Author
📸🩹 Test evidence
🩹 HACK-FORCED: signin line green 🩹 HACK-FORCED: tap navigates signin Captured by the agent's in-app test run (build-and-test). |
6 tasks
Contributor
Author
|
Superseded by #6105, which consolidates this and 11 other small GUI task branches into one PR/branch per the umbrella task's instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Asana task
Style the entire "Already have an account? Sign in" line on the getting-started USP carousel as the tertiary link color (
theme.iconTappable), not just the "Sign in" word. The line was already a single tap target (EdgeTouchableOpacitywraps both spans); only the color changes.USPs - Signin UI clarification
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Low Risk
Cosmetic color change on the getting-started screen only; no navigation, auth, or data handling changes.
Overview
On the getting-started USP carousel, the entire “Already have an account? Sign in” row now uses the tertiary link color (
theme.iconTappable), not only the “Sign in” span.tertiaryTextinGettingStartedSceneis updated fromtheme.textInputTextColorDisabledto matchtappableText. Tap behavior is unchanged—the row was already oneEdgeTouchableOpacitytarget.Reviewed by Cursor Bugbot for commit 6280f0b. Bugbot is set up for automated code reviews on this repo. Configure here.