Skip to content

Stop notification cards from shrinking their text#6088

Closed
j0ntz wants to merge 3 commits into
developfrom
jon/fix-notification-text-shrinkage
Closed

Stop notification cards from shrinking their text#6088
j0ntz wants to merge 3 commits into
developfrom
jon/fix-notification-text-shrinkage

Conversation

@j0ntz

@j0ntz j0ntz commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Description

Asana task

Notification Center cards (side menu → Notifications) shrank their own text. EdgeText defaults to adjustsFontSizeToFit={true}, and the card passed numberOfLines={3} with minimumFontScale={0.8} on the message and the 0.65 default on the title, so any notification whose message did not fit rendered smaller than its neighbours. Because the title and message share a height-constrained content container, the shrink cascaded to the title too, which is why one card in the reported screenshot is visibly smaller top to bottom.

The card now passes disableFontScaling on the title, timestamp and message, so every card renders at the same size and a message longer than three lines truncates with an ellipsis instead. This matches the requested behaviour: uniform cards, three lines, then "…". The home-screen banner (NotificationCard) already does the same thing on Android and is unchanged here.

Also included:

  • A standalone lint-fix commit for NotificationCenterCard (explicit React.FC types, shared themed CloseIcon instead of importing react-native-vector-icons directly), since committing the file graduates it off the lint suppression list.
  • A testID on the alert drop-down's close button so UI tests can dismiss it by selector rather than by coordinate.

Asana: https://app.asana.com/1/9976422036640/project/1200382638405084/task/1213213636561471

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Low Risk
Presentation-only notification UI and test/lint hygiene; no auth, payments, or data flow changes.

Overview
Notification center cards no longer shrink title, time, or message text to fit. The card passes disableFontScaling on those EdgeText fields and drops minimumFontScale on the message, so long copy truncates at numberOfLines (2 for title, 3 for message) with an ellipsis while every card stays the same height.

Lint / small extras: NotificationCenterCard is brought in line with project rules (explicit React.FC, themed CloseIcon instead of direct vector-icons) so it can come off the ESLint suppression list. AlertDropdown gets the same React.FC typing and testID="alertDropdownClose" on the dismiss control for UI tests. CHANGELOG documents the notification card fix.

Reviewed by Cursor Bugbot for commit eb2c1d8. Bugbot is set up for automated code reviews on this repo. Configure here.

j0ntz added 3 commits July 23, 2026 15:36
Add explicit React.FC return types and use the shared themed CloseIcon
instead of importing react-native-vector-icons directly.
Give the alert drop-down's close button a testID so UI tests can dismiss it
instead of tapping coordinates. Committing the file graduates it off the lint
suppression list, so AlertDropdown also picks up its explicit React.FC type.
The notification center relied on EdgeText's default adjustsFontSizeToFit,
so a card with a long message rendered its title and body at a smaller size
than its neighbors. Disable font scaling on the card text so every card
renders at the same size and overflowing text truncates with an ellipsis.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@j0ntz

j0ntz commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

📸 Test evidence

notification center uniform

notification center uniform

before fix reverted baseline

before fix reverted baseline

Captured by the agent's in-app test run (build-and-test).

@j0ntz

j0ntz commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #6105, which consolidates this and 11 other small GUI task branches into one PR/branch per the umbrella task's instructions.

@j0ntz j0ntz closed this Jul 24, 2026
@j0ntz
j0ntz deleted the jon/fix-notification-text-shrinkage branch July 24, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant