Skip to content

Clarify XRP minimum balance warning copy#6086

Closed
j0ntz wants to merge 1 commit into
developfrom
jon/xrp-minimum-balance-copy
Closed

Clarify XRP minimum balance warning copy#6086
j0ntz wants to merge 1 commit into
developfrom
jon/xrp-minimum-balance-copy

Conversation

@j0ntz

@j0ntz j0ntz commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Description

Asana task

Replaces the XRP minimum-balance warning copy shown in the "Minimum Balance Required" modal on the Request scene. The old text implied a user needed to deposit 1 XRP on top of their balance; the new text clarifies the reserve is met once the address balance itself reaches 1 XRP.

Asana task

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Low Risk
Copy-only change in English locale strings and CHANGELOG; no logic, API, or security impact.

Overview
Updates the Minimum Balance Required copy on the Request scene for XRP so it matches how the XRP Ledger reserve actually works.

The new text explains that 1 XRP is an unspendable network reserve, that the address is active once the balance reaches 1 XRP or more (not “deposit 1 XRP on top”), and that only amounts above the reserve are spendable. The string is wired through existing minimumPopupModals config (request_xrp_minimum_notification_body_1xrp in en_US.ts / enUS.json); the short alert line is unchanged. CHANGELOG documents the fix.

Reviewed by Cursor Bugbot for commit e502bce. Bugbot is set up for automated code reviews on this repo. Configure here.

Replace the XRP reserve warning body text so it no longer implies a
user must deposit 1 XRP in addition to their balance. The reserve is
met once the address balance itself reaches 1 XRP.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@j0ntz

j0ntz commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

📸 Test evidence

xrp minimum balance modal

xrp minimum balance modal

Captured by the agent's in-app test run (build-and-test).

@j0ntz

j0ntz commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #6105, which consolidates this and 11 other small GUI task branches into one PR/branch per the umbrella task's instructions.

@j0ntz j0ntz closed this Jul 24, 2026
@j0ntz
j0ntz deleted the jon/xrp-minimum-balance-copy branch July 24, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant