Clarify XRP minimum balance warning copy#6086
Closed
j0ntz wants to merge 1 commit into
Closed
Conversation
Replace the XRP reserve warning body text so it no longer implies a user must deposit 1 XRP in addition to their balance. The reserve is met once the address balance itself reaches 1 XRP.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Author
6 tasks
Contributor
Author
|
Superseded by #6105, which consolidates this and 11 other small GUI task branches into one PR/branch per the umbrella task's instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Asana task
Replaces the XRP minimum-balance warning copy shown in the "Minimum Balance Required" modal on the Request scene. The old text implied a user needed to deposit 1 XRP on top of their balance; the new text clarifies the reserve is met once the address balance itself reaches 1 XRP.
Asana task
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Low Risk
Copy-only change in English locale strings and CHANGELOG; no logic, API, or security impact.
Overview
Updates the Minimum Balance Required copy on the Request scene for XRP so it matches how the XRP Ledger reserve actually works.
The new text explains that 1 XRP is an unspendable network reserve, that the address is active once the balance reaches 1 XRP or more (not “deposit 1 XRP on top”), and that only amounts above the reserve are spendable. The string is wired through existing
minimumPopupModalsconfig (request_xrp_minimum_notification_body_1xrpinen_US.ts/enUS.json); the short alert line is unchanged. CHANGELOG documents the fix.Reviewed by Cursor Bugbot for commit e502bce. Bugbot is set up for automated code reviews on this repo. Configure here.