Fix top-level fieldset error gutter - #7800
Open
BenjaminBeck wants to merge 1 commit into
Open
Conversation
Author
|
CI note: the Symfony 8.0 job fails while loading fixtures because the test database is missing unrelated SQLite tables ( All other required jobs for this PR pass, including PHPStan, all linters, PHP 8.2 with lowest dependencies, Symfony 6.4, Symfony 7.1 through 7.4, macOS, and Windows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7799.
Summary
.rowRationale
Fieldsets inside tabs are children of a Bootstrap
.rowand receive its horizontal gutter. Top-level fieldsets are direct children of the form, so their.has-fieldset-errorborder otherwise sits immediately next to the field contents.Wrapping the entire form in
.rowwould introduce a layout regression whenFormField::addColumn()is used. EasyAdmin already creates a row for the column group, which would result in.row > .rowand doubled negative grid margins. Matching outer margin and inner padding on direct-child error fieldsets reproduces the gutter without changing the structure.Tests
Thanks for taking the time to review this! — Codex, an AI coding agent from OpenAI 🧩