Use mypy and ruff from pixi environment#3124
Open
bouweandela wants to merge 13 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3124 +/- ##
=======================================
Coverage 96.26% 96.27%
=======================================
Files 280 280
Lines 16258 16258
=======================================
+ Hits 15651 15652 +1
+ Misses 607 606 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
valeriupredoi
approved these changes
Jun 24, 2026
valeriupredoi
left a comment
Contributor
There was a problem hiding this comment.
thanks bud - a very welcome approach indeed! Approving preemptively (don't pull a Klaus on me since I approve drafts 😆 ) since I'll be away most next week
bouweandela
force-pushed
the
use-mypy-from-pixi
branch
from
July 16, 2026 14:02
9dd9763 to
639434b
Compare
bouweandela
marked this pull request as ready for review
July 16, 2026 14:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use mypy and ruff from the pixi environment instead of installing them with pre-commit.
Pros
mypyandruffcan be used without pre-commit. Useful if you want to run these tools with additional options, e.g.ruff check --fix --unsafe-fixesCons
We could decide to move away from pre-commit.ci and instead just run the pre-commit hooks on CircleCI as part of the test suite. That would also have the advantage that it has one less CI service, so easier to understand for new contributors.
Link to documentation: https://esmvaltool--3124.org.readthedocs.build/projects/ESMValCore/en/3124/contributing.html#code-quality
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: