Enhance plugin showcase and submission workflow with updates#65
Merged
Conversation
Keeps develop's newer package versions (showcase 1.2.0, webpack ^5.108.2, prettier 3.9.3) over main's def7264 updates.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
… and update success message
Contributor
⚡ Successfully deployed to Cloudflare Pages!
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the plugin submission and publishing workflows, refreshes a few dev dependencies, and adjusts configuration/docs to support an external screenshot service and clarified plugin metadata expectations.
Changes:
- Enforce restricted plugin tags (
favourite,docusaurus) in the plugin submission workflow by stripping them for non-maintainers and notifying the submitter. - Upgrade workflow actions and dev dependencies (e.g.,
actions/github-script,@types/node,prettier,webpack) and fix label removal input type. - Add
screenshotUrlconfiguration for plugin preview generation and clarifysourcemetadata expectations in docs.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
yarn.lock |
Updates locked versions/checksums for @types/node, prettier, and webpack. |
package.json |
Bumps dev dependency versions to match the lockfile updates. |
docusaurus.config.ts |
Adds a screenshotUrl option for the plugin showcase preset. |
contributing/plugins.mdx |
Clarifies when source is required vs allowed to be null/omitted. |
.github/workflows/publish.yml |
Updates action versions and corrects removeLabel input type. |
.github/workflows/create-plugin-pr.yml |
Adds restricted-tag enforcement and improves success comment formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and updates across the plugin submission workflow, documentation, and dependencies. The most significant change is the enforcement of restricted tags in plugin submissions, ensuring only maintainers can apply certain tags. It also upgrades several GitHub Actions and dependencies, clarifies plugin metadata requirements, and adds a new screenshot service configuration.
Plugin submission workflow improvements:
favourite,docusaurus) to plugin submissions. If a non-maintainer tries to use these tags, they are removed, and the submitter is notified in a comment. This helps maintain the integrity of highlighted/official listings. [1] [2]actions/github-scriptversion from v8 to v9 for both the plugin PR creation and publish workflows, and updates theactions/checkoutversion from v6 to v7 in the publish workflow. [1] [2] [3]Documentation and metadata requirements:
sourcefield in plugin metadata is required only for open source plugins; it can be omitted or set tonullfor closed source plugins.Configuration and dependency updates:
screenshotUrlconfiguration to use an external service for generating plugin preview images.@types/node,prettier, andwebpack.