ENG-2173 Enable props-based settings by default - #1349
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 648ac7480f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
mdroidian
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 256a34a417
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (graphSettingsMigrated && personalSettingsMigrated) { | ||
| await migratePropsStoreDefault(blockUids); |
There was a problem hiding this comment.
In a shared graph, once the first user reaches this call, Use new settings store becomes true in the graph-wide Feature Flags block, but every collaborator has a different personal block and migration marker. On another user's next load, bulkReadSettings() runs before initSchema() and therefore reads defaults from that user's not-yet-migrated personal block; for example, a legacy Disable product diagnostics opt-out becomes false and initPostHog() is called before this migration can repair the block. Unlike the earlier validation case, this occurs even when the second user's legacy data is valid, because this conditional cannot make an already-enabled graph flag wait for that user; the read gate needs per-user migration readiness.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing