Skip to content

ENG-2168 Add documentations for Advanced node search (Obsidian) - #1336

Merged
trangdoan982 merged 2 commits into
mainfrom
eng-2168-add-documentations-for-feature
Aug 24, 2026
Merged

ENG-2168 Add documentations for Advanced node search (Obsidian)#1336
trangdoan982 merged 2 commits into
mainfrom
eng-2168-add-documentations-for-feature

Conversation

@trangdoan982

@trangdoan982 trangdoan982 commented Aug 23, 2026

Copy link
Copy Markdown
Member

A user-facing docs page for the Obsidian advanced node search, at /docs/obsidian/core-features/node-search.

What changed

File
content/obsidian/core-features/node-search.md new — the page
content/obsidian/core-features/_meta.ts sidebar entry, between "Node tags" and "Querying"
public/docs/obsidian/node-search-*.png 5 screenshots

No docsRouteMap.ts change: a brand-new page has no legacy flat route to preserve.

Verification

Rendered on a local dev server:

  • page renders, no console errors
  • sidebar shows "Node search" in the right position
  • all 5 images load (naturalWidth > 0, not just a 200)
  • all 3 cross-links — command palette, node tags, bulk identify — return 200

Side observation

Unrelated and untouched: `bulk-identify-discourse-nodes` is missing from `OBSIDIAN_DOC_SECTIONS` in `docsRouteMap.ts`, so `/docs/obsidian/bulk-identify-discourse-nodes` has no flat redirect while its siblings in that section do.

Scope check

  • Ran `$scope-check` against ENG-2168 and the final diff.
  • Scope beyond `Done When`: None. The sidebar entry and the screenshots are what make "web documentation is added" true — an unregistered page does not appear in the docs, and the docs conventions call for real screenshots over placeholders.

🤖 Generated with Claude Code


Open in Devin Review

Add a core-features page for the advanced node search feature, covering the
whole beta rather than only what has merged: ranked search with preview and
badges, the type filter dropdown, keyboard tag chips, sort, and the footer
actions including insert-link-at-cursor.

Sort (ENG-2112, #1320) and insert link at cursor (ENG-2114, #1314) are still
open, so this page should land with or after them.

Screenshots are of the running plugin, captured against the combined
advanced-search-beta build so the sort and insert-link surfaces were present.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@linear-code

linear-code Bot commented Aug 23, 2026

Copy link
Copy Markdown

ENG-2168

@supabase

supabase Bot commented Aug 23, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@vercel

vercel Bot commented Aug 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
discourse-graph Ready Ready Preview Aug 24, 2026 4:29am

Request Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@trangdoan982 trangdoan982 changed the title ENG-2168 Add documentations for feature ENG-2168 Add documentations for Advanced node search (Obsidian) Aug 23, 2026
@trangdoan982
trangdoan982 merged commit cf6cd91 into main Aug 24, 2026
8 checks passed
@trangdoan982
trangdoan982 deleted the eng-2168-add-documentations-for-feature branch August 24, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants