Fix pydantic error In SLURM API model as gres_detail field can be an empty list#310
Open
isikhar wants to merge 1 commit into
Open
Fix pydantic error In SLURM API model as gres_detail field can be an empty list#310isikhar wants to merge 1 commit into
isikhar wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #310 +/- ##
==========================================
- Coverage 81.41% 81.35% -0.06%
==========================================
Files 31 31
Lines 5730 5755 +25
Branches 330 332 +2
==========================================
+ Hits 4665 4682 +17
- Misses 989 995 +6
- Partials 76 78 +2 🚀 New features to boost your workflow:
|
Contributor
|
Empty string or missing string? IIRC the OpenAPI spec is manual, so this must just be a mistake |
Contributor
Author
|
Jobs triggering |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently SLURM API v0.0.44 allows
gres_detailfield to be an empty string that results in current model implementation raising a pydantic error.This patch fixes this issue enabling
JobInfoGresDetailtype object to be an empty list.