[codex] Serialize token refresh across Dio instances#578
Merged
Conversation
jjoonleo
force-pushed
the
feature/fix-token-refresh-race
branch
from
a9c25ef to
6f4497e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
AppDioas a lazy singleton so app API callers share one configured Dio client.TokenInterceptorrefresh coordination to process-wide state so concurrent 401s across multiple interceptor instances queue behind one refresh request.Why
Production logs showed default preparation updates returning
200, followed immediately by access/refresh credential failures. The backend rotates refresh tokens, so concurrent refresh attempts with the same old token can make all but the first request fail as stale. Serializing refresh coordination on the client prevents those spurious logout/error paths.Validation
dart run build_runner build --delete-conflicting-outputsflutter test test/core/dio/interceptors/token_interceptor_test.dartflutter analyzeflutter test