-
Notifications
You must be signed in to change notification settings - Fork 28
Decouple display and recording/inference FPS #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
C-Achard
wants to merge
33
commits into
cy/gentl-trigger-ui
Choose a base branch
from
cy/limit-display-fps
base: cy/gentl-trigger-ui
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
97fa138
Add GenTL hardware trigger support
C-Achard 51ab19e
Handle camera trigger defaults & trigger-aware startup
C-Achard 5040aab
Improve signal handling and graceful shutdown
C-Achard a2eca8e
Add GenTL trigger tests and fake node map
C-Achard ec6c898
Respect user camera order for display/tiling
C-Achard ea9f2a9
tests: preserve display order and add MultiCamera tests
C-Achard cd9c5ab
Mock _maybe_allow_keyboard_interrupt in GUI tests
C-Achard 53ea4c2
Support strict GenTL trigger and defaults
C-Achard e6aa601
Apply gentl trigger defaults when saving
C-Achard 4dd3b4d
Don't sort available camera IDs
C-Achard 9b61a3e
Preserve DLC config using model_copy
C-Achard e2c15b3
Warn when GenTL TriggerMode fails to enable
C-Achard 65b33a3
Improve GenTL trigger routing safety and tests
C-Achard 646ac99
Cap hardware-trigger fetch timeout and update tests
C-Achard e9789d8
Interruptible camera waits; simplify config save
C-Achard 1f5bd21
Potential fix for pull request finding
C-Achard d4548c9
Fix broken suggestion
C-Achard 6e7b3e8
Resolve 'auto' trigger source in GenTL backend
C-Achard 7e72c0b
Add trigger settings dialog and UI button
C-Achard 45fd768
Add per-camera hardware trigger settings
C-Achard 9b6d31b
Update trigger_config_dialog.py
C-Achard 0edfbbf
Use _is_preview_live and clear trigger timeout
C-Achard 1780065
Restart active previews; ignore bad trigger
C-Achard 9f6493d
Improve trigger dialog defaults and error handling
C-Achard a4d0714
Add worker timing logs to camera worker
C-Achard 59a2449
Add per-camera timing to MultiCameraController
C-Achard f201917
Add pretty/str/repr to CameraSettings
C-Achard 2332c3f
Reduce lock scope and refactor frame handling
C-Achard 68bea86
Split multi-camera frame signals; throttle display
C-Achard 66ba349
Add GenTL telemetry and frame-rate debugging
C-Achard ebccbce
Remove temp debug block
C-Achard 070e4a0
Fix missing signal wiring
C-Achard 0560d43
Allow zero node values and reduce log level
C-Achard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving open as reminder