Fix imdb_movie_picker: correct indentation, parameterize SQL, add err… - #123
JoexBlaze89 wants to merge 1 commit into
Conversation
…or handling, env-configurable API key and DB path
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c6f77451f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| continue | ||
|
|
||
| try: | ||
| resp = requests.get(f"http://www.omdbapi.com/?i={imdb_id}&apikey={API_KEY}", timeout=5) |
There was a problem hiding this comment.
When OMDB_API_KEY is configured, this request places that caller-provided credential in a plaintext http:// URL. On an untrusted network, an observer can recover the key and consume its OMDb quota; use the HTTPS endpoint for this request.
Useful? React with 👍 / 👎.
| except Exception: | ||
| # network error or invalid json; try again | ||
| continue |
There was a problem hiding this comment.
If the configured key is invalid, OMDb returns a persistent HTTP error, or the network is unavailable, raise_for_status()/JSON parsing enters this handler and the outer while True immediately retries forever. The script consequently never tells the user why it cannot obtain a movie and can generate unbounded failed requests; bound retries or report unrecoverable errors.
Useful? React with 👍 / 👎.
| CREATE TABLE IF NOT EXISTS movies_watched ( | ||
| id INTEGER PRIMARY KEY AUTOINCREMENT, | ||
| imdb_id TEXT UNIQUE | ||
| ); |
There was a problem hiding this comment.
For a movie.db created by the previous version, movies_watched already exists with imdb_id INTEGER and no unique constraint. CREATE TABLE IF NOT EXISTS does not alter that schema, so INSERT OR IGNORE still inserts duplicate IMDb IDs despite the new function contract; migrate the existing table or create a unique index before relying on the constraint.
Useful? React with 👍 / 👎.
1 participant
…or handling, env-configurable API key and DB path